-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MovingWindow] Add a trigger that fires after having received a fixed number of samples #967
Comments
It would be great if this could be part of v1.0 since we are still working around this with sleep calls. What was the issue with the implementation in the PR that was mentioned above? |
It think it should not be hard to implement using a condition. Just add a wait method that calls There was an attempt using a channel to communicate when the samples were received, but I'm not sure that complexity is needed, if we need a receiver, we can use (an expose) an |
Actually Channels could be seen as a convenience wrapper on top of condition objects. |
AFAIR there is no issue. Someone has to pick it up. |
I can pick this up next week if no one is already looking into this. |
That would be great, I am pretty sure that no one is on it yet. |
What's needed?
Currently there is no clean way to wait until the MovingWindow got updated with a certain number of samples.
This feature has been requested in the past and there has been an initial implemented attempt #387.
This feature has been requested again now by @cwasicki.
Proposed solution
Introduce an asynchronous
wait_for_samples
method that returns once the requested number of new samples has been stored in theMovingWindow
.Use cases
Forecast actor
(Add method to MovingWindow that waits for a number of samples #387 (comment))Alternatives and workarounds
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: