Pull Request Template

[mweinelt]

We need a pull request template to improve on applying our guidelines and better able to track progress of pull requests.

@skorpy2009 and @rotanid wanted to take care of that. I recommend HackMD to collaborately build the text and neoraider recommended to use HTML comments to hide explanations etc..

Make use of our notes from the meeting here: https://md.darmstadt.ccc.de/gluon-device-support-policy#

[skorpy2009]

This depends on #1438 & #1434

[mweinelt]

GitHub allows for several different types of ISSUE_TEMPLATEs, probably the same for pull requests, so we don't need to cram everything into a single template.

https://blog.github.com/2018-05-02-issue-template-improvements/

via https://github.com/ffrgb/meshviewer/tree/develop/.github/ISSUE_TEMPLATE

[rotanid]

@mweinelt you can only add a single PR template at the moment, as far as i can see it

EDIT: ok, they are possible, but not easily available to a user...

[mweinelt]

Sure, but better start somewhere, GitHub will follow at some point.

[rotanid]

sure, feel free to do a pull request adding templates ;)

[mweinelt]

Great, let's do it collaboratively:

https://md.darmstadt.ccc.de/gluon-templates

[christf]

which problem are we addressing with these templates?

[mweinelt]

Lack of information and structure in pull requests. Like when you add a new device you'd get the device checklist by default.

The issue is that we currently can only have on PR template as it looks.

[mweinelt]

This did not pan out, which is fine, since nobody seems to be complaining about the current state of PR descriptions.

On top of that GitHub still does not support multiple PR templates and offering the device integration checklist as a default is a non-starter.