Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPTIONS requests incomplete for AttorneySerializer and PartySerializer #4933

Open
ERosendo opened this issue Jan 16, 2025 · 0 comments
Open

OPTIONS requests incomplete for AttorneySerializer and PartySerializer #4933

ERosendo opened this issue Jan 16, 2025 · 0 comments
Assignees
@ERosendo

Comments

@ERosendo
Copy link
Contributor

While intended to address handling a custom attribute for nested filtering in #4729, changes to AttorneySerializer and PartySerializer using SerializerMethodFields impacted the self-describing API schemas for these views. This affects the output generated during OPTIONS requests to the endpoints.

I believe the following suggestion from DRF document could fix this issue: The Django REST Framework documentation suggests a solution for this issue: https://www.django-rest-framework.org/api-guide/schemas/#map_field
@ERosendo ERosendo self-assigned this Jan 16, 2025
@mlissner mlissner moved this to Jan 27 - Feb 7 in Sprint (Web Team) Jan 16, 2025
@mlissner mlissner changed the title Update AttorneySerializer and PartySerializer OPTIONS requests incomplete for AttorneySerializer and PartySerializer Jan 24, 2025
@mlissner mlissner moved this from Next 1.0 to Next 0.99 in Sprint (Web Team) Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ERosendo ERosendo

Labels
None yet
Projects
Sprint (Web Team)
Status: Jan 27 to Feb. 7 ♻️
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ERosendo