Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax error in securedrop-remove-packages.service ConditionPathExists #7412

Open
legoktm opened this issue Jan 14, 2025 · 2 comments · May be fixed by #7434
Open

Syntax error in securedrop-remove-packages.service ConditionPathExists #7412

legoktm opened this issue Jan 14, 2025 · 2 comments · May be fixed by #7434
Assignees
@legoktm
Milestone
SecureDrop 2.12.0

Comments

@legoktm
Copy link
Member

legoktm commented Jan 14, 2025 •
edited
Loading

Description

securedrop/securedrop/debian/config/lib/systemd/system/securedrop-remove-packages.service

Lines 3 to 4 in 3f737a2

ConditionPathExists|=/usr/sbin/ufw
ConditionPathExists|=/usr/sbin/haveged

Stupid typo on my part, |= is wrong, it's supposed to be =|. This shows up when you run systemctl daemon-reload.

There's no real adverse effect, it just ends up invoking apt more often than necessary, so I'm flagging this for the 2.12 release.

Would be good to figure out a regression test for this in the future, especially since systemd can clearly spot the error.
@legoktm legoktm added this to the SecureDrop 2.12.0 milestone Jan 14, 2025
@legoktm
Copy link
Member Author

legoktm commented Jan 14, 2025 

$ systemd-analyze verify securedrop/debian/config/lib/systemd/system/securedrop-remove-packages.service
/home/user/github/freedomofpress/securedrop/securedrop/debian/config/lib/systemd/system/securedrop-remove-packages.service:3: Unknown key 'ConditionPathExists|' in section [Unit], ignoring.
/home/user/github/freedomofpress/securedrop/securedrop/debian/config/lib/systemd/system/securedrop-remove-packages.service:4: Unknown key 'ConditionPathExists|' in section [Unit], ignoring.
/usr/lib/systemd/system/qubes-gui-agent.service:15: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
securedrop-remove-packages.service: Command /usr/bin/apt-get is not executable: No such file or directory

So probably we can get that to work. Maybe it needs to be a staging check? Idk.

@rocodes
Copy link
Contributor

rocodes commented Jan 16, 2025

In case it's helpful, on the workstation side of things I put up a draft PR with some basic systemd testing of our expected unit files over there; it can probably be reused once it's a bit more polished freedomofpress/securedrop-workstation#1234

@zenmonkeykstop zenmonkeykstop self-assigned this Jan 22, 2025
@legoktm legoktm assigned legoktm and unassigned zenmonkeykstop Jan 31, 2025
legoktm added a commit that referenced this issue Jan 31, 2025
@legoktm
Fix syntax of systemd's ConditionPathExists
dc0ab2a 
systemd prefers =|, not |=.

Fixes #7412.
@legoktm legoktm linked a pull request Jan 31, 2025 that will close this issue
Open
3 tasks
@legoktm legoktm moved this to In Progress in SecureDrop dev cycle Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@legoktm legoktm

Labels
None yet
Projects
SecureDrop dev cycle
Status: In Progress
Milestone
SecureDrop 2.12.0
Development

Successfully merging a pull request may close this issue.

Fix syntax of systemd's ConditionPathExists freedomofpress/securedrop
3 participants
@legoktm @zenmonkeykstop @rocodes