Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui polish] Star colors #590

Closed
6 tasks
ninavizz opened this issue Oct 25, 2019 · 1 comment
Closed
6 tasks

[ui polish] Star colors #590

ninavizz opened this issue Oct 25, 2019 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@ninavizz
Copy link
Member

ninavizz commented Oct 25, 2019

As it is

Currently Sources in the Source List follow an incorrect color convention. Starred sources are a black fill with no outline, and un-starred sources have no fill and a black outline. When this feature extends to the the Source Header atop the Conversation Pane for the selected source, the below will apply as well.

Made to shine!

  • SVG art, here in the Content Inventory
  • Un-starred stars have hover states, but starred stars do not.
  • Within the Source List, stars should be styled...
    • Starred: {width: 17px; height: 16px; box-shadow: 0 0 3px 0 #ffffff; background-color: #2a319d;} <—aka GrimaceBlue
    • Un-Starred: {width: 17px; height: 16px; box-shadow: 0 0 3px 0 #ffffff; background-color: #d8d8d8;}
    • Un-Starred, hover: `{width: 17px; height: 16px; box-shadow: 0 0 10px 0 rgba(5, 237, 254, 0.73); border: solid 2px rgba(42, 49, 157, 0.59); background-color: #ffffff;}
    • Note: in Zeplin, only the selected Source shows the box-shadow, but to keep things simple it's ok if all of them have the white box-shadow
  • Inside the Source Header at the top of the Conversation Pane, stars should be styled...
    • NOTE: The below are only applicable once the Starring feature has been extended to include this location; as of the writing of this Issue, there is no starting in the Source Header.
    • Starred: {width: 31px; height: 29px; box-shadow: 0 0 12px 0 rgba(255, 255, 255, 0.6); border: solid 1px #ffffff; background-color: GrimaceBlue;}
    • Un-Starred: {width: 31px; height: 29px; box-shadow: 0 0 12px 0 rgba(255, 255, 255, 0.6); border: solid 1px #ffffff; background-color: #e3e8f8;}
    • Un-Starred, hover: `{width: 31px; height: 29px; box-shadow: 0 0 12px 3px #ffffff; border: solid 2px rgba(42, 49, 157, 0.53); background-color: #f8fafe;}'
    • Note: In the above Zeplin mox, the stars are two different sizes and one has a decimal value. Please follow sizing, above. As with the Source List stars, both starred and un-starred inside the Source Header can maintain the white box-shadow.
@redshiftzero redshiftzero added the help wanted Extra attention is needed label Oct 25, 2019
@eloquence
Copy link
Member

From 2022-08-15 review with @gonzalo-bulnes @eloquence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants