kyua report-junit does not properly escape non-printable characters in <system-out> and <system-err>

[rodrigc]

To reproduce:

(1) Create a Kyuafile:

syntax(2)

test_suite("test1")

plain_test_program{name="test1.sh"}

(2) Create test1.sh

#!/bin/sh
man ls

(3) Run the test, create JUnit test report:

kyua test
kyua report-junit --output=report.xml

(4) Import the report.xml into the Jenkins test report viewer.

The Jenkins test report viewer will give errors and refuse to import the test report.
The section in report.xml has non-printable ASCII characters which are invalid XML.
These characters need to be escaped.

The only non-printable ASCII characters which are OK in XML are carriage returns, line feeds,
spaces, and tabs. Everything else needs to be escaped. See: https://support.microsoft.com/kb/315580/en-us
for an example

I think the following function should be expanded to escape more characters:
https://github.com/jmmv/kyua/blob/master/utils/text/operations.cpp#L45

[jmmv]

Cool. I didn't know which characters needed escaping, so the referenced code just did stuff on a trial and error basis. Will look.

[ngie-eign]

Ping.

This issue is preventing me from writing test cases and integrating them in to FreeBSD. Example: https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1497/

[jmmv]

I dropped the ball on this (and many other things lately). I have left some comments in the pull request.

I now have to figure out how to push a new release with this fix. I have been delaying it because HEAD is not fully functional; there is one little regression to be fixed in the TAP parser, but it is an annoying one to fix... I'll probably have to cherrypick a bunch of fixes and cut a micro-release instead of a full release from HEAD just so that this can be made available to you soon.