Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PR's don't use the grey icon #205

Closed
tooomm opened this issue Dec 30, 2020 · 4 comments
Closed

Draft PR's don't use the grey icon #205

tooomm opened this issue Dec 30, 2020 · 4 comments

Comments

@tooomm
Copy link
Contributor

tooomm commented Dec 30, 2020

Notifications for open, closed and merged PR's show their special icons.
Same like open and closed issues use different ones, too.

Draft PR's are not supported yet.

@tooomm
Copy link
Contributor Author

tooomm commented Jan 20, 2021

Thanks for looking into that and adding a grey PR logo for Draft PR's, it works!

The exact colour can be hard to spot though, it's pretty dark.
Did you try a bit lighter version as well? I guess the icon is to small for using outlines only?

@freaktechnik
Copy link
Owner

freaktechnik commented Jan 20, 2021

The extension currently uses the exact colors github uses (or at least used at time of implementation of features, the red and green might be slightly off since dark mode became a thing).

Edit also wondering when it is hard to spot, I'd assume in the normal light look it should be fine? Don't know what the Firefox dark theme does to it, admittedly.

@tooomm
Copy link
Contributor Author

tooomm commented Jan 25, 2021

I do not use dark mode or any other theme for Firefox - all default.

The used colour might be the accurate representation of what GitHub uses, the colour impression when displayed as small is different though.
On the GitHub page it's easier to recognizing PR types by their coloured icons.
In the extension however, the grey seems kinda dark and when looked at it in isolation (without having red closed PR's or green open PR's around which use the same icon type) you can not be sure that it's grey for "draft".
One could easily mix it up with a generic icon for a pull request as its "dark" (=generic black) than "grey".

That's why I asked if you tried a bit lighter grey as well. Maybe that's easier to correctly connect with "draft" right away.

@tooomm
Copy link
Contributor Author

tooomm commented Feb 8, 2021

Finally got around to take some screenshots. I can't help it, but it looks super difficult to differentiate easily/quickly for me...
On GitHub itself it's a bit easier as the icon is bigger - still not perfect.

  • Your addon:
    addon

  • GitHub notification page:
    github

I doubts it's my monitor as I use an Eizo with PVA panel. On the internal laptop display with TN panel it's the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants