-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft PR's don't use the grey icon #205
Comments
Thanks for looking into that and adding a grey PR logo for The exact colour can be hard to spot though, it's pretty dark. |
The extension currently uses the exact colors github uses (or at least used at time of implementation of features, the red and green might be slightly off since dark mode became a thing). Edit also wondering when it is hard to spot, I'd assume in the normal light look it should be fine? Don't know what the Firefox dark theme does to it, admittedly. |
I do not use dark mode or any other theme for Firefox - all default. The used colour might be the accurate representation of what GitHub uses, the colour impression when displayed as small is different though. That's why I asked if you tried a bit lighter grey as well. Maybe that's easier to correctly connect with "draft" right away. |
Finally got around to take some screenshots. I can't help it, but it looks super difficult to differentiate easily/quickly for me... I doubts it's my monitor as I use an Eizo with PVA panel. On the internal laptop display with TN panel it's the same. |
Notifications for open, closed and merged PR's show their special icons.
Same like open and closed issues use different ones, too.
Draft PR's are not supported yet.
The text was updated successfully, but these errors were encountered: