Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Make sidebar items link full width #196

Closed
jonathan-richer opened this issue Nov 22, 2023 · 0 comments · Fixed by #197
Closed

style: Make sidebar items link full width #196

jonathan-richer opened this issue Nov 22, 2023 · 0 comments · Fixed by #197

Comments

@jonathan-richer
Copy link
Contributor

I would like the sidebar links to be full width. It'll make it easier to navigate through the sidebar and also be consistent with the sidebar groups which are full-width. And when I say "full-width", I mean "the available space in the sidebar except the margins."

I have looked through the scss files and I found that this the div parent of the link prevents the expansion of the a element. I have tested changing this line from margin-right: auto; to width: 100%; which fixed this.

I am not sure I understand the need for the margin-right property, so if there is an explanation, please enlighten me.

@BreadGenie BreadGenie linked a pull request Nov 22, 2023 that will close this issue
@jonathan-richer jonathan-richer changed the title FEATURE: Make sidebar items link full width style: Make sidebar items link full width Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant