From 1f173ca2e0d58ea71bb43f080403f06acf20bed0 Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Fri, 22 Nov 2024 14:44:46 +0530 Subject: [PATCH] refactor: better handling of get parameters --- .../doctype/braintree_settings/braintree_settings.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/payments/payment_gateways/doctype/braintree_settings/braintree_settings.py b/payments/payment_gateways/doctype/braintree_settings/braintree_settings.py index 717443e8..850c6301 100644 --- a/payments/payment_gateways/doctype/braintree_settings/braintree_settings.py +++ b/payments/payment_gateways/doctype/braintree_settings/braintree_settings.py @@ -267,11 +267,17 @@ def create_charge_on_braintree(self): status = "Error" redirect_url = "payment-failed" + get_parameters = [ + ("doctype", self.data.reference_doctype), + ("docname", self.data.reference_docname), + ] + if redirect_to: - redirect_url += "?" + urlencode({"redirect_to": redirect_to}) + get_parameters.append(("redirect_to", redirect_to)) if redirect_message: - redirect_url += "&" + urlencode({"redirect_message": redirect_message}) + get_parameters.append(("redirect_message", redirect_message)) + redirect_url += "?" + urlencode(get_parameters) return {"redirect_to": redirect_url, "status": status}