From d68577979b1c3c40ba99058dc51b5110ac8e5ea9 Mon Sep 17 00:00:00 2001
From: Saqib Ansari <nextchamp.saqib@gmail.com>
Date: Sun, 18 Feb 2024 18:13:00 +0530
Subject: [PATCH 1/5] fix: initial limit and update limit

---
 frontend/src/query/visual/LimitSection.vue    | 10 ++++++----
 frontend/src/query/visual/useAssistedQuery.js |  6 ++++++
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/frontend/src/query/visual/LimitSection.vue b/frontend/src/query/visual/LimitSection.vue
index 91378301a..08a897f82 100644
--- a/frontend/src/query/visual/LimitSection.vue
+++ b/frontend/src/query/visual/LimitSection.vue
@@ -1,14 +1,16 @@
 <script setup>
 import { watchDebounced } from '@vueuse/core'
 import { Infinity } from 'lucide-vue-next'
-import { inject, ref } from 'vue'
+import { inject, ref, watch } from 'vue'
 import SectionHeader from './SectionHeader.vue'
 
 const assistedQuery = inject('assistedQuery')
 const limit = ref(assistedQuery.limit)
-watchDebounced(limit, (value) => (assistedQuery.limit = value || assistedQuery.limit), {
-	debounce: 300,
-})
+watchDebounced(limit, assistedQuery.setLimit, { debounce: 300 })
+watch(
+	() => assistedQuery.limit,
+	(val) => (limit.value = val)
+)
 </script>
 
 <template>
diff --git a/frontend/src/query/visual/useAssistedQuery.js b/frontend/src/query/visual/useAssistedQuery.js
index acbf5db20..78ed2576c 100644
--- a/frontend/src/query/visual/useAssistedQuery.js
+++ b/frontend/src/query/visual/useAssistedQuery.js
@@ -46,6 +46,7 @@ export default function useAssistedQuery(query) {
 		removeFilterAt,
 		updateFilterAt,
 		setOrderBy,
+		setLimit,
 		addTransform,
 		removeTransformAt,
 		updateTransformAt,
@@ -181,6 +182,11 @@ export default function useAssistedQuery(query) {
 		})
 	}
 
+	function setLimit(limit) {
+		if (limit === state.limit) return
+		state.limit = limit
+	}
+
 	function addTransform() {
 		state.transforms.push({ type: '', options: {} })
 		query.updateTransforms(state.transforms)

From efb0daaf2dda4401cc4fdf2c18cc36cb764b0d1f Mon Sep 17 00:00:00 2001
From: Saqib Ansari <nextchamp.saqib@gmail.com>
Date: Sun, 18 Feb 2024 18:35:07 +0530
Subject: [PATCH 2/5] fix: cannot set transforms

---
 frontend/src/query/resources/useQuery.js      | 39 ++++++++++---------
 frontend/src/query/useQueryResource.js        |  1 +
 .../doctype/insights_query/insights_query.py  |  6 ---
 .../insights_query/insights_query_client.py   |  5 +++
 .../insights/doctype/insights_query/utils.py  |  2 +-
 5 files changed, 28 insertions(+), 25 deletions(-)

diff --git a/frontend/src/query/resources/useQuery.js b/frontend/src/query/resources/useQuery.js
index 468a034cd..9ac375c29 100644
--- a/frontend/src/query/resources/useQuery.js
+++ b/frontend/src/query/resources/useQuery.js
@@ -24,7 +24,7 @@ export default function useQuery(name) {
 		sourceSchema: {},
 	})
 
-	const run = createTaskRunner()
+	const queue = createTaskRunner()
 	state.doc = computed(() => resource.doc)
 
 	const setLoading = (value) => (state.loading = value)
@@ -52,11 +52,11 @@ export default function useQuery(name) {
 
 	state.updateTitle = (title) => {
 		setLoading(true)
-		return run(() => resource.setValue.submit({ title }).finally(() => setLoading(false)))
+		return queue(() => resource.setValue.submit({ title }).finally(() => setLoading(false)))
 	}
 	state.changeDataSource = (data_source) => {
 		setLoading(true)
-		return run(() => resource.setValue.submit({ data_source }).then(() => setLoading(false)))
+		return queue(() => resource.setValue.submit({ data_source }).then(() => setLoading(false)))
 	}
 
 	const autoExecuteEnabled = settingsStore().settings.auto_execute_query
@@ -66,7 +66,7 @@ export default function useQuery(name) {
 
 		setLoading(true)
 		return new Promise((resolve) =>
-			run(() =>
+			queue(() =>
 				resource.setValue
 					.submit({ json: JSON.stringify(newQuery, null, 2) })
 					.then(() => autoExecuteEnabled && state.execute())
@@ -80,7 +80,7 @@ export default function useQuery(name) {
 		if (!state.doc?.data_source) return
 		setLoading(true)
 		state.executing = true
-		await run(() => resource.run.submit().catch(() => {}))
+		await queue(() => resource.run.submit().catch(() => {}))
 		await state.results.reload()
 		state.executing = false
 		setLoading(false)
@@ -89,37 +89,40 @@ export default function useQuery(name) {
 	state.updateTransforms = debounce(async (transforms) => {
 		if (!transforms) return
 		setLoading(true)
-		return run(() =>
-			resource.setValue
-				.submit({ transforms, status: 'Pending Execution' })
-				.then(() => autoExecuteEnabled && state.execute())
+		const updateTransform = () => resource.setValue.submit({ transforms })
+		const updateStatus = () => resource.set_status.submit({ status: 'Pending Execution' })
+		const autoExecute = () => autoExecuteEnabled && state.execute()
+		return queue(() =>
+			updateTransform()
+				.then(updateStatus)
+				.then(autoExecute)
 				.finally(() => setLoading(false))
 		)
 	}, 500)
 
 	state.duplicate = async () => {
 		state.duplicating = true
-		await run(() => resource.duplicate.submit())
+		await queue(() => resource.duplicate.submit())
 		state.duplicating = false
 		return resource.duplicate.data.message
 	}
 
 	state.delete = async () => {
 		state.deleting = true
-		await run(() => resource.delete.submit())
+		await queue(() => resource.delete.submit())
 		state.deleting = false
 	}
 
 	state.store = () => {
 		setLoading(true)
-		return run(() => resource.store.submit().finally(() => setLoading(false)))
+		return queue(() => resource.store.submit().finally(() => setLoading(false)))
 	}
 	state.unstore = () => {
 		setLoading(true)
-		return run(() => resource.unstore.submit().finally(() => setLoading(false)))
+		return queue(() => resource.unstore.submit().finally(() => setLoading(false)))
 	}
 	state.switchQueryBuilder = () => {
-		return run(() => {
+		return queue(() => {
 			return resource.switch_query_type.submit().then(() => {
 				window.location.reload()
 			})
@@ -160,7 +163,7 @@ export default function useQuery(name) {
 	state.convertToNative = async () => {
 		if (state.doc.is_native_query) return
 		setLoading(true)
-		return run(() => {
+		return queue(() => {
 			return resource.setValue
 				.submit({ is_native_query: 1, is_assisted_query: 0, is_script_query: 0 })
 				.finally(() => setLoading(false))
@@ -171,7 +174,7 @@ export default function useQuery(name) {
 	state.executeSQL = debounce((sql) => {
 		if (!sql || sql === state.doc.sql) return state.execute()
 		setLoading(true)
-		return run(() =>
+		return queue(() =>
 			resource.setValue
 				.submit({ sql })
 				.then(() => state.execute())
@@ -183,13 +186,13 @@ export default function useQuery(name) {
 	state.updateScript = debounce((script) => {
 		if (script === state.doc.script) return
 		setLoading(true)
-		return run(() => resource.setValue.submit({ script }).finally(() => setLoading(false)))
+		return queue(() => resource.setValue.submit({ script }).finally(() => setLoading(false)))
 	}, 500)
 
 	state.updateScriptVariables = debounce((script_variables) => {
 		if (variables === state.doc.variables) return
 		setLoading(true)
-		return run(() => resource.setValue.submit({ variables }).finally(() => setLoading(false)))
+		return queue(() => resource.setValue.submit({ variables }).finally(() => setLoading(false)))
 	}, 500)
 
 	state.downloadResults = () => {
diff --git a/frontend/src/query/useQueryResource.js b/frontend/src/query/useQueryResource.js
index e0fdb732b..0fa71f8a9 100644
--- a/frontend/src/query/useQueryResource.js
+++ b/frontend/src/query/useQueryResource.js
@@ -7,6 +7,7 @@ export const API_METHODS = {
 	unstore: 'unstore',
 	convert: 'convert',
 	setLimit: 'set_limit',
+	set_status: 'set_status',
 	duplicate: 'duplicate',
 	reset: 'reset_and_save',
 	fetchTables: 'fetch_tables',
diff --git a/insights/insights/doctype/insights_query/insights_query.py b/insights/insights/doctype/insights_query/insights_query.py
index a893e1e0b..45586150f 100644
--- a/insights/insights/doctype/insights_query/insights_query.py
+++ b/insights/insights/doctype/insights_query/insights_query.py
@@ -52,12 +52,6 @@ def after_insert(self):
 
     def before_save(self):
         self.variant_controller.before_save()
-        self.handle_transform_change()
-
-    def handle_transform_change(self):
-        if self.has_value_changed("transforms"):
-            self.update_query_results()
-            self.status = Status.PENDING.value
 
     def on_update(self):
         self.link_chart()
diff --git a/insights/insights/doctype/insights_query/insights_query_client.py b/insights/insights/doctype/insights_query/insights_query_client.py
index 565d53903..86a5d4744 100644
--- a/insights/insights/doctype/insights_query/insights_query_client.py
+++ b/insights/insights/doctype/insights_query/insights_query_client.py
@@ -17,6 +17,11 @@
 
 
 class InsightsQueryClient:
+    @frappe.whitelist()
+    def set_status(self, status):
+        # since status is auto set based on the sql, we need some way to override it
+        self.db_set("status", status)
+
     @frappe.whitelist()
     def duplicate(self):
         new_query = frappe.copy_doc(self)
diff --git a/insights/insights/doctype/insights_query/utils.py b/insights/insights/doctype/insights_query/utils.py
index 051219c28..e35ada7f8 100644
--- a/insights/insights/doctype/insights_query/utils.py
+++ b/insights/insights/doctype/insights_query/utils.py
@@ -74,7 +74,7 @@ def update_sql(query):
     if query.sql == sql:
         return
     query.sql = sql
-    query.update_query_results([])
+    query.update_query_results()
     query.status = Status.PENDING.value if sql else Status.SUCCESS.value
 
 

From a89899a7ebce1fb45c622b473a63a6b251f1460f Mon Sep 17 00:00:00 2001
From: Saqib Ansari <nextchamp.saqib@gmail.com>
Date: Mon, 19 Feb 2024 19:00:36 +0530
Subject: [PATCH 3/5] fix: attached file name overflow

---
 frontend/src/components/Controls/Attachment.vue | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/frontend/src/components/Controls/Attachment.vue b/frontend/src/components/Controls/Attachment.vue
index 0e003c1a7..43af505e8 100644
--- a/frontend/src/components/Controls/Attachment.vue
+++ b/frontend/src/components/Controls/Attachment.vue
@@ -1,5 +1,5 @@
 <template>
-	<div class="flex flex-col text-base">
+	<div class="flex flex-col overflow-hidden text-base">
 		<span class="mb-2 block text-sm leading-4 text-gray-700">
 			{{ label || 'Attach File' }}
 		</span>
@@ -14,14 +14,14 @@
 		/>
 
 		<!-- Upload Button -->
-		<Button v-if="!file?.name" class="form-input h-7" @click="upload" :loading="uploading">
+		<Button v-if="!file?.name" @click="upload" :loading="uploading">
 			<FeatherIcon name="upload" class="mr-1 inline-block h-3 w-3" />
 			{{ placeholder || 'Upload a file' }}
 		</Button>
 
 		<!-- Clear Button -->
-		<Button v-else class="form-input h-7" iconRight="x" @click="clear">
-			{{ file.file_name }}
+		<Button v-else iconRight="x" @click="clear">
+			<span class="truncate">{{ file.file_name }}</span>
 		</Button>
 	</div>
 </template>

From ae113e0cfa21dd3e3a14248c42798a8a24fa9109 Mon Sep 17 00:00:00 2001
From: Saqib Ansari <nextchamp.saqib@gmail.com>
Date: Tue, 20 Feb 2024 13:25:16 +0530
Subject: [PATCH 4/5] fix: close button doesn't work in expression editor
 dialog

---
 .../query/visual/ColumnExpressionEditor.vue   | 11 +++----
 frontend/src/query/visual/ColumnSection.vue   | 29 ++++++++++---------
 2 files changed, 19 insertions(+), 21 deletions(-)

diff --git a/frontend/src/query/visual/ColumnExpressionEditor.vue b/frontend/src/query/visual/ColumnExpressionEditor.vue
index f8664dade..b342761fc 100644
--- a/frontend/src/query/visual/ColumnExpressionEditor.vue
+++ b/frontend/src/query/visual/ColumnExpressionEditor.vue
@@ -15,7 +15,7 @@ const emptyExpressionColumn = {
 }
 
 const assistedQuery = inject('assistedQuery')
-const emit = defineEmits(['save', 'discard', 'remove'])
+const emit = defineEmits(['save', 'remove'])
 const props = defineProps({ column: Object })
 
 const propsColumn = props.column || emptyExpressionColumn
@@ -83,12 +83,9 @@ function onSave() {
 			</div>
 		</div>
 
-		<div class="flex flex-col justify-between gap-2 lg:flex-row">
-			<Button variant="outline" @click="emit('discard')"> Discard </Button>
-			<div class="flex flex-col gap-2 lg:flex-row">
-				<Button variant="outline" theme="red" @click="emit('remove')">Remove</Button>
-				<Button variant="solid" :disabled="!isValid" @click="onSave"> Save </Button>
-			</div>
+		<div class="flex flex-col justify-end gap-2 lg:flex-row">
+			<Button variant="outline" theme="red" @click="emit('remove')">Remove</Button>
+			<Button variant="solid" :disabled="!isValid" @click="onSave"> Save </Button>
 		</div>
 	</div>
 </template>
diff --git a/frontend/src/query/visual/ColumnSection.vue b/frontend/src/query/visual/ColumnSection.vue
index c4adfdfe1..92cc24a4e 100644
--- a/frontend/src/query/visual/ColumnSection.vue
+++ b/frontend/src/query/visual/ColumnSection.vue
@@ -147,20 +147,21 @@ function onColumnSort(e) {
 		</DraggableList>
 	</div>
 
-	<Dialog
-		:modelValue="showExpressionEditor"
-		:options="{
-			title: 'Column Expression',
-			size: '3xl',
-		}"
-	>
-		<template #body-content>
-			<ColumnExpressionEditor
-				:column="columns[activeColumnIdx]"
-				@remove="onRemoveColumn"
-				@save="onSaveColumn"
-				@discard="activeColumnIdx = null"
-			/>
+	<Dialog :modelValue="showExpressionEditor" :options="{ size: '3xl' }">
+		<template #body>
+			<div class="bg-white px-4 pb-6 pt-5 sm:px-6">
+				<div class="flex items-center justify-between pb-4">
+					<h3 class="text-2xl font-semibold leading-6 text-gray-900">
+						Column Expression
+					</h3>
+					<Button variant="ghost" @click="activeColumnIdx = null" icon="x"> </Button>
+				</div>
+				<ColumnExpressionEditor
+					:column="columns[activeColumnIdx]"
+					@remove="onRemoveColumn"
+					@save="onSaveColumn"
+				/>
+			</div>
 		</template>
 	</Dialog>
 </template>

From eeb06093987371738b31b51f6ba7801fdbeb2e72 Mon Sep 17 00:00:00 2001
From: Saqib Ansari <nextchamp.saqib@gmail.com>
Date: Wed, 21 Feb 2024 13:07:51 +0530
Subject: [PATCH 5/5] fix: public chart doesn't render

---
 frontend/src/components/Charts/BaseChart.vue |  2 +-
 frontend/src/query/PublicChart.vue           | 12 +-----------
 frontend/src/query/usePublicChart.js         |  4 +++-
 3 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/frontend/src/components/Charts/BaseChart.vue b/frontend/src/components/Charts/BaseChart.vue
index 758250bac..148417d30 100644
--- a/frontend/src/components/Charts/BaseChart.vue
+++ b/frontend/src/components/Charts/BaseChart.vue
@@ -1,7 +1,7 @@
 <script setup>
 import { areDeeplyEqual } from '@/utils'
 import * as echarts from 'echarts'
-import { onBeforeUnmount, onMounted, onUpdated, ref, watch } from 'vue'
+import { onBeforeUnmount, onMounted, ref, watch } from 'vue'
 import ChartTitle from './ChartTitle.vue'
 
 const props = defineProps({
diff --git a/frontend/src/query/PublicChart.vue b/frontend/src/query/PublicChart.vue
index da84e7b87..290db4769 100644
--- a/frontend/src/query/PublicChart.vue
+++ b/frontend/src/query/PublicChart.vue
@@ -14,15 +14,5 @@ const chart = usePublicChart(props.public_key)
 		:data="chart.data"
 		:options="chart.doc.options"
 		:key="JSON.stringify(chart.doc.options)"
-	>
-		<template #placeholder>
-			<InvalidWidget
-				class="absolute"
-				title="Insufficient options"
-				message="Please check the options for this chart"
-				icon="settings"
-				icon-class="text-gray-500"
-			/>
-		</template>
-	</component>
+	/>
 </template>
diff --git a/frontend/src/query/usePublicChart.js b/frontend/src/query/usePublicChart.js
index d184bfa7b..cc0922f4e 100644
--- a/frontend/src/query/usePublicChart.js
+++ b/frontend/src/query/usePublicChart.js
@@ -1,5 +1,6 @@
 import { safeJSONParse } from '@/utils'
 import { getFormattedResult } from '@/utils/query/results'
+import { convertResultToObjects } from '@/widgets/useChartData'
 import { createResource } from 'frappe-ui'
 import { reactive } from 'vue'
 
@@ -22,7 +23,8 @@ export default function usePublicChart(publicKey) {
 	async function load() {
 		state.loading = true
 		state.doc = await resource.fetch()
-		state.data = getFormattedResult(state.doc.data)
+		const results = getFormattedResult(state.doc.data)
+		state.data = convertResultToObjects(results)
 		state.loading = false
 	}
 	load()