Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality issue in the Calendar view of Attendance doctype #2466

Closed
1 task done
ArunaDevraj opened this issue Nov 29, 2024 · 4 comments · Fixed by #2739
Closed
1 task done

Functionality issue in the Calendar view of Attendance doctype #2466

ArunaDevraj opened this issue Nov 29, 2024 · 4 comments · Fixed by #2739
Assignees
Labels
bug Something isn't working released

Comments

@ArunaDevraj
Copy link

Information about bug

When logged in as an employee myself, I am able to view the attendance records of all other employees in the "Calendar View" format. This is a potential data privacy concern. A screenshot of the issue has been attached for reference.

Screenshot from 2024-11-29 12-25-58

Module

HR

Version

ERPNext - v15.42.0 (version-15)
Frappe Framework: v15.47.2 (version-15)
Frappe HR: v15.23.0 (version-15)

Installation method

manual install

Relevant log output / Stack trace / Full Error Message.

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ArunaDevraj ArunaDevraj added the bug Something isn't working label Nov 29, 2024
@ArunaDevraj
Copy link
Author

I solved the issue by editing the core attendance.py file. (Path: home/frappe-user/frappe-bench/apps/hrms/hrms/hr/doctype/attendance/attendance.py)
I also attached the screenshot of the code and the obtained output.

Screenshot from 2024-11-29 12-29-53

Screenshot from 2024-11-29 12-28-03

@ruchamahabal
Copy link
Member

will have to change this API to return permission-sensitive calendar events with get_list

def get_events(start, end, filters=None):

Currently does a raw sql query

@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 14.36.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 15.39.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants