Fix bad regex (issue #119) #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some issues with the regex that this commit fixes: * The first one is that `[v|V]` is already a range, so there is no need for the `|`. * The current regex is actually expecting either `v` or `V` in the version, but that is not required, so we make the entire `[vV]` optional, by wrapping it into a `()?`. * Because a missing `v` or `V` will still match as an empty match (`""`), we need to exclude the result, so we make the group optional: `?:`
|
This is a fix for #119 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some issues with the regex that this commit fixes:
[v|V]is already a range, so there is no need for the|.vorVin the version, but that is not required, so we make the entire[vV]optional, by wrapping it into a()?.vorVwill still match as an empty match (""), we need to exclude the result, so we make the group optional:?: