This repository has been archived by the owner on Jun 11, 2021. It is now read-only.
feat(react): introduce inputRef for focus management
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
reviewed
Feb 26, 2020
| if (inputRef.current) { | ||
| inputRef.current.focus(); | ||
| } | ||
| }, 0); |
There was a problem hiding this comment.
Is it the part you said it won't focus without setTimeout?
There was a problem hiding this comment.
Yes, using the autoFocus prop triggers this message:
Autofocus processing was blocked because a document already has a focused element.
Focusing at the end of the event loop works though.
eunjae-lee
approved these changes
Feb 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
inputRefprop to the React renderer and showcases it with a story in a modal.This prop is forwarded to the renderer so that users have control on the focus management of the input. In this story, it wouldn't have been possible to focus the input without this addition.
See preview →