From d6993bc8d2416077594b53ff67d1302a23f704c5 Mon Sep 17 00:00:00 2001 From: akynaston Date: Wed, 30 Oct 2024 16:05:01 -0600 Subject: [PATCH] Update FixOldTypo.php - remove extra 'Hello world' This whole framework is amazing; however, this particular verification seemed to be mildly confusing ending up with two 'Hello world' values as the correct string. I think the more natural fix is to just expect it once, right? --- backend/hook/verifications/FixOldTypo.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/hook/verifications/FixOldTypo.php b/backend/hook/verifications/FixOldTypo.php index d0def20..391bfa9 100644 --- a/backend/hook/verifications/FixOldTypo.php +++ b/backend/hook/verifications/FixOldTypo.php @@ -8,6 +8,6 @@ protected function doVerify() $commits = $this->ensureCommitsCount(2); $this->verifyTypoIsFixed($commits[1]); $fileContent = implode(' ', $this->getFileContent($commits[0], 'file.txt')); - $this->ensure($fileContent == 'Hello world Hello world is an excellent program.', "You haven't resolved the conflict correctly."); + $this->ensure($fileContent == 'Hello world is an excellent program.', "You haven't resolved the conflict correctly."); } }