Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debt(foundry-common): Refactor ens utility to alloy #7127

Open
Evalir opened this issue Feb 14, 2024 · 2 comments
Open

debt(foundry-common): Refactor ens utility to alloy #7127

Evalir opened this issue Feb 14, 2024 · 2 comments
Labels
A-internals Area: internals D-chore Difficulty: chore T-debt Type: code debt

Comments

@Evalir
Copy link
Member

Evalir commented Feb 14, 2024

#7122 introduces NameOrAddress which is capable of resolving an ens name to an address. Once providers on alloy are more stable (when alloy-rs/alloy#190 is merged), we should refactor this as an extension crate to alloy.
@gakonst gakonst added this to Foundry Feb 14, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Feb 14, 2024
@Evalir Evalir added T-feature Type: feature D-chore Difficulty: chore labels Feb 14, 2024
@zerosnacks zerosnacks changed the title chore(foundry-common): Refactor ens utility to alloy debt(foundry-common): Refactor ens utility to alloy Jul 11, 2024
@zerosnacks zerosnacks added T-debt Type: code debt A-internals Area: internals and removed T-feature Type: feature labels Jul 11, 2024
@zerosnacks zerosnacks self-assigned this Jul 11, 2024
@zerosnacks
Copy link
Member

zerosnacks commented Jul 11, 2024 •
edited
Loading

@DaniPopes / @mattsse Is this something we still would want to do?

Related file: https://github.com/foundry-rs/foundry/blob/master/crates/common/src/ens.rs

@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@zerosnacks
Copy link
Member

zerosnacks commented Jul 30, 2024 •
edited
Loading

Related ticket in Alloy: alloy-rs/alloy#491, leaving this ticket open to mirror the one in Alloy so it can be moved over once implemented.

@zerosnacks zerosnacks removed their assignment Jul 30, 2024
@zerosnacks zerosnacks added the T-blocked Type: blocked label Jul 30, 2024
@zerosnacks zerosnacks removed the T-blocked Type: blocked label Sep 16, 2024
@grandizzy grandizzy removed this from the v1.0.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-internals Area: internals D-chore Difficulty: chore T-debt Type: code debt
Projects
Foundry
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Evalir @grandizzy @zerosnacks