Replies: 3 comments 1 reply
-
cc @gabe-l-hart |
Beta Was this translation helpful? Give feedback.
0 replies
-
I think this sounds great @yhwang! The only suggestion I'd add would be to make the mTLS configuration optional. Some users may be content with TLS termination and insecure comms within the cluster, so it would be nice to enable these users without the complexity of mTLS. |
Beta Was this translation helpful? Give feedback.
1 reply
-
created a PR: #21 for this design |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently, there is a specific service account for the Pod which has the designated Role and RoleBinding for the driver to update the LMEvalJob's status and upload the results. Here is an idea to remove the Role and RoleBinding and allow the driver to update the status and results
Run a secure gRPC server in the controller and expose a set of APIs for the driver to update the LMEvalJob's status and results. The APIs are:
On the driver side, it uses the gRPC client to invoke the APIs to update the status and results
Use mTLS as the protocol authentication + token or key-based authorization. In this case, we need the cert, key, and CA on the controller and Pods. Since we already have the cert on the controller for the webhooks, we can reuse it. So we only need
When the controller creates the Pods, it specifies the secrets(yes, we need two secrets here, one for the client's key and one for the server CA cert) which contain the cert, key, and CA for the mTLS and also the secret for the token/API-Key.
Any suggestions/comments?
Beta Was this translation helpful? Give feedback.
All reactions