Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve generation parameter passing in orchestrator server #32

Open
gkumbhat opened this issue May 13, 2024 · 0 comments
Open

Improve generation parameter passing in orchestrator server #32

gkumbhat opened this issue May 13, 2024 · 0 comments
Labels
enhancement New feature or request Medium Priority

Comments

@gkumbhat
Copy link
Collaborator

Description

Currently we are manually re-defining the parameters required by the text generation API manually here. This can be fragile and limiting if TGIS API changes for these parameters, or if they add new parameter etc.

It would be good to use generation proto def directly to define that part of the API, or take that in as a JSON object and pass it along as is to underlying generation server. This would avoid us getting in the middle of the generation parameters we can accept.

@gkumbhat gkumbhat added the enhancement New feature or request label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Medium Priority
Projects
None yet
Development

No branches or pull requests

1 participant