Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate between detect and detect_content #178

Open
gkumbhat opened this issue Aug 23, 2024 · 0 comments
Open

De-duplicate between detect and detect_content #178

gkumbhat opened this issue Aug 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@gkumbhat
Copy link
Collaborator

Description

Currently we have a bit of duplicate logic between detect and detect_content added in PR: #177 .. we let the duplication in to get the APi fixing change in quickly.

However, this could potentially create confusion apart from making the code harder to read so we need to figure out right way to de-duplicate it.
@gkumbhat gkumbhat mentioned this issue Aug 23, 2024
Merged
@evaline-ju evaline-ju changed the title Re-duplicate between detect and detect_content De-duplicate between detect and detect_content Aug 23, 2024
@evaline-ju evaline-ju added the enhancement New feature or request label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gkumbhat @evaline-ju