ARCv3: Fix displayed L2$ size #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelvkozlov
requested changes
Apr 2, 2024
arch/arc/include/asm/cluster.h
Outdated
| data_bank_wid:2, data_sub_banks:2, cache_sets:5, | ||
| data_bank_sz:5, data_banks:3, cache_tag_banks:3, | ||
| cache_blk_sz:1, cache_assoc:4, scm_cache:1, res:1; | ||
| #else | ||
| unsigned int res:1, scm_cache:1, cache_assoc:4, cache_blk_sz:1, | ||
| cache_tag_banks:3, data_banks:3, data_bank_sz:5, | ||
| cache_sets:5, data_sub_banks:2, data_bank_wid:2, | ||
| superblocks:3, res1:2; | ||
| superblocks:3, data_bank_sz_75:1, res1:1; |
There was a problem hiding this comment.
Changes in this file are not linked with the L2$ size fix. Please, add this change by a separate commit.
arch/arc/mm/cache-arcv3.c
Outdated
| @@ -51,7 +52,9 @@ static int read_decode_cache_bcr_arcv3(int c, char *buf, int len) | |||
| if (cln0.has_scm) { | |||
| READ_BCR(ARC_REG_CLNR_SCM_BCR_0, scm0); | |||
|
|
|||
| p_l2->sz_k = (1 << scm0.data_bank_sz) * (1 << scm0.data_banks); | |||
| assoc = (scm0.cache_assoc == 0) ? 16 : scm0.cache_assoc; | |||
| p_l2->sz_k = (scm0.cache_blk_sz << 6) * assoc * (1 << scm0.cache_sets); | |||
There was a problem hiding this comment.
I think you need to use the L1_CACHE_SHIFT definition instead of decimal-literal 6. The definition is formed from the CONFIG_ARC_CACHE_LINE_SHIFT option.
There was a problem hiding this comment.
The documentation states that the cache line size for ARСv3 is fixed and the size is 64 bytes. Let's rely on this and also fix the size = 64 bytes in code.
xxkent
force-pushed
the
bolsh-fix-cache-size
branch
from
5e82412
to
3f700f8
Compare
xxkent
force-pushed
the
bolsh-fix-cache-size
branch
from
3f700f8
to
f0e7412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.