Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom font for golden tests in preference for FlutterTest font #337

Open
kawaijoe opened this issue Jan 4, 2025 · 2 comments
Open
Assignees
Labels
type: ehancement A new feature or request

Comments

@kawaijoe
Copy link
Member

kawaijoe commented Jan 4, 2025

Golden tests with custom fonts can be flaky as fonts are rendered differently based on the platform/flutter version. It could be worth considering migrating to the default FlutterTest font to ensure the tests are rendered consistently.

Additional resources

@kawaijoe kawaijoe added the type: ehancement A new feature or request label Jan 4, 2025
@Pante
Copy link
Member

Pante commented Jan 4, 2025

We probably should split the migration equally across multiple people. Having a single person do it is going to be soul crushing.

On another note, this should only proceed after we thoroughly investigated the layout test library.

@kawaijoe kawaijoe self-assigned this Jan 12, 2025
@kawaijoe kawaijoe moved this from Triage to Assigned in Forui Roadmap Jan 12, 2025
@Pante
Copy link
Member

Pante commented Jan 16, 2025

We're currently evaluating an alternative where flutter golden tests are ran inside a ubuntu docker image. This will allow us to eliminate flakiness while retaining the benefits of using actual fonts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: ehancement A new feature or request
Projects
Status: Assigned
Development

No branches or pull requests

2 participants