-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typescript - don't autoclose type arguments #181
Comments
See #24 how to cope but this should really be working out of the box as it's super annoying in most popular languages. @formulahendry Is there any good reason why default activation list is not limited to markup based languages? |
The solution on #24 totally disables autoclose on tsx, which is not the desirable behavior. Would it be possible to use some language context to decide when to close a tag or not? |
I believe a proper solution to that problem is tracked in microsoft/vscode#1751 but perhaps some hack could be implemented in the meantime. |
Bump, hope this can be fixed soon. |
Okay, the fix for me was that vscode has builtin support for auto closing tags. Just got rid of this extension. P.S. auto rename is also builtin now, both of these plugins are obsolete i guess 🙃 |
Adding to @tusharsadhwani update: There's a VSCode settings called The auto closing feature is done using This does make the plugin obsolete for me, and solve the original issue. Thanks for pointing that out! |
Thanks @tusharsadhwani & @JulioC Thank you @formulahendry for developing the extension which has been useful to me over the past couple of years 👍 |
When using this extension in Typescript files, type arguments are detected as HTML and autoclosed, which means that I have to manually delete the erroneously created tag.
I know that I could disable the extension on
.ts
and.tsx
files, however the autoclosing functionality is still useful in these files when working on React project.Is there a way that the extension can detect when the tags being created are TS type arguments and not autoclose in this situation?
The text was updated successfully, but these errors were encountered: