bug: not persisting layout on lock-screen #300
Comments
|
ah, just blanking the screen is enough to trigger this. |
|
Hi @jubalfh, when the code was reviewed by Extension admins for GNOME 45, session persistence handling was removed. disable is being called when the screen blanks out or logs out |
|
Huh. I would think that if any plugin needs persistence, if only to keep the layout from changes, it would be a tiling/tabbing extension. In case the reviewers couldn't be convinced, would it be much work to make forge serialise the layout state somewhat on blanking/locking and restore it on activation? Right now, forge stopped matching my (admittedly, very idiosyncratic) workflow almost entirely: i usually keep a number of differently tabbed windows on two physical displays (× at least three workspaces), and aligning all of them manually after each screen lock is simply untenable. |
|
Getting the GNOME 45 support out the door quickly was a priority during that time. Here are the options:
|
|
@jubalfh - try it out and let me know. Then I can petition it. Thanks |
|
@jmmaranan thank you for extremely quick reaction! i've checked out the fix-unlock-dialog branch and am running it right now, but the behaviour seems to be the same. (if it helps, it seems that the layout reset happens just a moment after unlocking). the only line in gnome-shell log that looks remotely relevant is this: |
|
Did you quickly try to unlock as soon as screen comes up? Or waited a little bit? |
|
I tried both, and did a suspend for good measure; this layout reset seems consistent. |
|
@jubalfh - It works on my machine :) If it is OK with you, I can merge it now and try to publish it too and hopefully it passes and then you can also try it from the official package.
|
jmmaranan
changed the title
|
just confirming that the fix works for me, thank you very much! |
|
Thanks. There is a little bit of uphill on the GNOME review. But I think all is well. Maybe few days in EGO package. |
|
Every time the lock screen appears my current layout is lost. Is there any additional setting for it to work properly? |
Description
After upgrade to GNOME 45 (Ubuntu 23.04 → 23.10) there's a behaviour change: locking and unlocking screen causes tabbed windows to lose tabbed state (they're being retiled instead).
As before upgrade, I'm running a Wayland session.
Expected Behavior
After locking and unlocking screen, the tabbed windows should keep they previous layout.
Reproduction
Upgrade to GNOME 45 seems to be a required step.
Steps To Reproduce
Details
Mark with [ ] all that applies:
It happens with any application?
It happens only on one computer?
It happens only with some specific gnome configuration?
It happens only with some specific extension installed?
Diagnostics
At every screen lock/unlock action.
Environment
Linux metatron 6.5.0-9-generic #9-Ubuntu SMP PREEMPT_DYNAMIC Sat Oct 7 01:35:40 UTC 2023 x86_64 x86_64 x86_64 GNU/LinuxDisplay Setup
Displays:
Notebook 1920x1080 60hz
Output and Logs
Gnome Logs
Command:
journalctl --since='1 hour ago' --follow /usr/bin/gnome-shelljournalctl --since='1 hour ago' --follow /usr/bin/gnome-shell
System from 1 hour ago
Command:
journalctl -b 0 -r --since '1 hour ago':Not relevant, the only difference are unrelated system services.
Extension Configuration
Command:
dconf dump /org/gnome/shell/extensions/forge/Enabled Extensions
Command:
gnome-extensions list --enabled --detailsGraphics information
Command:
lshw -C display$ lshw -C display *-display description: VGA compatible controller product: HD Graphics 5500 vendor: Intel Corporation physical id: 2 bus info: pci@0000:00:02.0 logical name: /dev/fb0 version: 09 width: 64 bits clock: 33MHz capabilities: msi pm vga_controller bus_master cap_list rom fb configuration: depth=32 driver=i915 latency=0 resolution=1920,1080 resources: irq:48 memory:e0000000-e0ffffff memory:c0000000-dfffffff ioport:3000(size=64) memory:c0000-dffffMonitor information
NOTE: i'm running wayland; this is XWayland idea of a screen.
Command:
xrandr --properties | grep -vE '(x|\s|\.|\d)+$'The text was updated successfully, but these errors were encountered: