fix(deps): bump kit #379
Merged
fix(deps): bump kit #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
bump kit
explanation: I don't know why, but the bundle tests don't seem to like it when you've got different versions of a dependency. In this situation, it's kit. The private method it's complaining about hasn't changed in 3 years. We just made a PR to kit to make it not exist on the class to avoid this in the future.
But the real solution to make sure all the bundler tests aren't constantly throwing false positives is to keep your dependencies current (ex: dependabot + automerge gha)
What issues does this PR fix or reference?
https://github.com/forcedotcom/sfdx-core/actions/runs/9565816018/job/26369656862
needed for @W-10271718@