Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert deps core and kit #374

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: revert deps core and kit #374

merged 1 commit into from
Jun 6, 2024

Conversation

peternhale
Copy link
Collaborator

@W-15724695@

@peternhale peternhale requested a review from daphne-sfdc June 6, 2024 12:27
Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

In salesforcedx-apex, I switched to the phale/revert branch and ran git clean -xfd, yarn install, yarn build, yarn link.

In plugin-apex, I used the following dependencies:

  "dependencies": {
    "@oclif/core": "^3.26.4",
    "@salesforce/apex-node": "6.0.1",
    "@salesforce/core": "^7.3.9",
    "@salesforce/kit": "^3.1.2",
    "@salesforce/sf-plugins-core": "^9.1.1",
    "chalk": "^5.3.0",
    "color-convert": "^2.0.1",
    "color-name": "^2.0.0"
  },

I ran git clean -xfd, yarn install, yarn build, yarn link @salesforce/apex-node, then yarn build again. All steps work as expected and both builds pass.

@peternhale peternhale merged commit d647363 into main Jun 6, 2024
14 of 16 checks passed
@peternhale peternhale deleted the phale/revert branch June 6, 2024 13:20
gilgourevitch pushed a commit to gilgourevitch/salesforcedx-apex that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants