feat: add JSON result to test:run command #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnanyaJha
commented
Dec 1, 2020
| @@ -431,13 +437,14 @@ export class TestService { | |||
| str = str.slice(0, -1); | |||
|
|
|||
| const perTestCodeCovQuery = | |||
| 'SELECT ApexTestClassId, ApexClassOrTrigger.Id, ApexClassOrTrigger.Name, TestMethodName, NumLinesCovered, NumLinesUncovered FROM ApexCodeCoverage WHERE ApexTestClassId IN (%s)'; | |||
| 'SELECT ApexTestClassId, ApexClassOrTrigger.Id, ApexClassOrTrigger.Name, TestMethodName, NumLinesCovered, NumLinesUncovered, Coverage FROM ApexCodeCoverage WHERE ApexTestClassId IN (%s)'; | |||
There was a problem hiding this comment.
CLI json result expects Coverage info for each ApexCodeCoverage record
AnanyaJha
commented
Dec 1, 2020
| @@ -397,10 +399,13 @@ export type ApexCodeCoverage = { | |||
|
|
|||
| export type PerTestCoverage = { | |||
| apexClassOrTriggerName: string; | |||
| apexClassorTriggerId: string; | |||
| apexClassOrTriggerId: string; | |||
There was a problem hiding this comment.
nit: capitalizing the Or to be consistent
lcampos
reviewed
Dec 1, 2020
| @@ -241,6 +246,57 @@ describe('force:apex:test:run', () => { | |||
| expect(result).to.not.contain('Apex Code Coverage by Class'); | |||
| }); | |||
|
|
|||
| test | |||
There was a problem hiding this comment.
Let's add a test with failed & skipped data results
lcampos
reviewed
Dec 1, 2020
| }; | ||
| }; | ||
|
|
||
| export class JsonReporter { |
There was a problem hiding this comment.
Do we need unit tests for this or do we think the ones that execute the oclif command are good enough ?
There was a problem hiding this comment.
Added some more tests!
AnanyaJha
added a commit
that referenced
this pull request
Dec 2, 2020
AnanyaJha
added a commit
that referenced
this pull request
Dec 2, 2020
klewis-sfdc
pushed a commit
that referenced
this pull request
Oct 24, 2022
WillieRuemmele
pushed a commit
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds formatting to return the correct JSON result. Added more info to the library result so we can use it for this new JSON result
What issues does this PR fix or reference?
@W-8320712@