This repository has been archived by the owner on Dec 6, 2018. It is now read-only.
Implemented driver for BH1750 light sensor #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static constexpr uint16_t measurement_time_ms_high = 200; | ||
|
|
||
| //! Current resolution mode | ||
| static bh1750_cfg::resolution resolution; |
There was a problem hiding this comment.
Could you please prefix it with m_ part, that's how class members are distinguished from other variables or names.
It very useful when using auto-complete and for redability.
|
Couple of style nitpicks. |
vadimol
force-pushed
the
bh1750_develop_branch
branch
from
18af076 to
3b16a59
Compare
|
addressed comments |
|
Looks good, thanks! |
forGGe
added a commit
that referenced
this pull request
May 29, 2016
Implemented driver for BH1750 light sensor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.