-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to install particular fonts #4
Comments
I suggest multiline strings if you do in fact do this: - uses: fontist/setup@v1
with:
fonts: Fira Code - uses: fontist/setup@v1
with:
fonts: |
Fira Code
Inter There's even a core method for it: Examples from actions/cache and actions/upload-artifact: - name: Save Primes
id: cache-primes-save
uses: actions/cache/save@v4
with:
path: |
path/to/dependencies
some/other/dependencies
key: ${{ steps.cache-primes-restore.outputs.cache-primary-key }} - uses: actions/upload-artifact@v4
with:
name: my-artifact
path: |
path/output/bin/
path/output/test-results
!path/**/*.tmp |
I would be cautious about this. I haven't seen any other setup-$THING action install packages or things on-the-spot when setting up. So I don't know if they don't do it for a reason or something or what. setup-node, setup-python, setup-ruby, etc. seem to always leave package installation (even global package installation) to either a package.json requirements.txt or Cargo.toml or whatever OR they rely on you to # 3x lines
- uses: fontist/setup@v1
with:
fonts: Fira Code vs # 2x lines
- uses: fontist/setup@v1
- run: fontist install "Fira Code" also you could shorten it even more if # 2x lines
- uses: fontist/setup@v1
- run: fontist install "Fira Code" "Inter" "Open Sans" "Consolas" "Arial" "Times New Roman" vs # lots of lines 🤷♂️
- uses: fontist/setup@v1
with:
fonts: |
Fira Code
Inter
Open Sans
Consolas
Arial
Times New Roman |
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true # runs 'bundle install' and caches installed gems automatically We could use Lines 18 to 20 in 5922aae
What about something like this: - uses: fontist/setup@v1
with:
manifest: true # The manifest is at manifest.y{a,}ml As a side node, perhaps |
Right now the user needs to specify additional lines to install fonts, as in:
It would be much better if we can specify the fonts to install directly:
GitHub Actions arguments only support
string | number | boolean
so we can't use an array, but multiple fonts can be specified using semicolons or commas (since ?The text was updated successfully, but these errors were encountered: