Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slider does not work sometimes #716

Closed
digi604 opened this issue May 2, 2019 · 3 comments
Closed

slider does not work sometimes #716

digi604 opened this issue May 2, 2019 · 3 comments
Assignees
@lubber-de
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.7.6

Comments

@digi604
Copy link
Contributor

digi604 commented May 2, 2019

Bug Report

If the min value of slider is not 0 but 1 the scale is incorrect shows 01 - 101 even though the max is 10.

Steps to reproduce

  1. create a slider with: min: 1, max: 10, step: 2

Expected result

scale starts at 1 and ends at 10

Actual result

Screenshot (when possible)

Screenshot 2019-05-02 at 15 24 05

Version

2.7.2
@digi604
Copy link
Contributor Author

digi604 commented May 2, 2019

Also 10 should never be reachable as it starts at 1 and step is 2

@y0hami
Copy link
Member

y0hami commented May 2, 2019

Can you create a JSFiddle to help replicate the issue?

@lubber-de lubber-de self-assigned this May 17, 2019
@lubber-de lubber-de mentioned this issue May 17, 2019
Merged
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript and removed 📝 needs test case labels May 17, 2019
@lubber-de lubber-de added this to the 2.7.6 milestone May 17, 2019
@lubber-de
Copy link
Member

Fixed by #751
See https://jsfiddle.net/1mqo5gju/1/

@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label May 20, 2019
@y0hami y0hami closed this as completed in 014b7ef Jun 16, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lubber-de lubber-de

Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.6
Development

No branches or pull requests
3 participants
@digi604 @y0hami @lubber-de