Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] checkbox doesn't respect form size #666

Closed
donaggio opened this issue Apr 12, 2019 · 3 comments
Closed

[Form] checkbox doesn't respect form size #666

donaggio opened this issue Apr 12, 2019 · 3 comments
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@donaggio
Copy link

[Form] checkbox doesn't respect form size

Steps to reproduce

  1. Define a .ui.form of a given size, ex.: .ui.tiny.form
  2. Add an input and a checkbox to the form

Expected result

All fields inside the form should inherit their font-size from the size variation of the parent form itself

Actual result

It works for input fields but not for checkboxes

Testcase

https://jsfiddle.net/a1sxk7du/

Version

2.7.4

@exoego
Copy link
Contributor

exoego commented Apr 12, 2019

Confirmed.

❌ checkbox
✔️ input
✔️ textarea
✔️ dropdown (select)
✔️ message

Only checkbox does not respect the size of parent form.

@exoego exoego added tag/good-first-issue Good issues for new starters to try lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug labels Apr 12, 2019
@lubber-de
Copy link
Member

Related SUI issue: Semantic-Org/Semantic-UI#3941
Jack said, it is using px instead of em because of rounding issues... 🤔 Could not really reproduce in a short test.
Anyway, leaving the checkbox as it is (by 17px width/height) and adjust by transform:scale() seems to easily do the job without dealing with top-margins (which would be necessary if done only via width/height adjustments) Just by scaling, the checkbox always stays centered to the label text...
Here is some testing: https://jsfiddle.net/mygbzvfc/

@lubber-de lubber-de added the tag/sui-issue Taken from an existing Issue/PR of SUI label Apr 12, 2019
@lubber-de
Copy link
Member

Fixed by #886
See your adjusted jsfiddle here: https://jsfiddle.net/vkjzudc6/

@lubber-de lubber-de removed the tag/good-first-issue Good issues for new starters to try label Jul 19, 2019
@lubber-de lubber-de added this to the 2.7.7 milestone Jul 19, 2019
@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jul 25, 2019
@y0hami y0hami closed this as completed in 58fdc6a Jul 28, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

3 participants