Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accordion][Header] Header with content has display:none when in an accordion element #102

Closed
Atulin opened this issue Sep 4, 2018 · 2 comments
Assignees
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@Atulin
Copy link

Atulin commented Sep 4, 2018

Steps

  1. Create an accordion
  2. In the visible part, add a header with content inside
<h2 class="ui grey header">
    <i class="newspaper outline padded icon"></i>
    <div class="content">
        <span class="s-title">Top 10 anime fights</span>
        <div class="sub header s-author">By John Johnson</div>
     </div>
 </div>

Expected Result

Header is visible, like it was prior to me upgrading from SUI to FUI.

Actual Result

Header receives display: none:
image

Version

2.5

Testcase

https://jsfiddle.net/29onq46h/

@ColinFrick ColinFrick added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Sep 4, 2018
@ColinFrick ColinFrick added this to the 2.5.x milestone Sep 4, 2018
@ColinFrick ColinFrick self-assigned this Sep 4, 2018
@prudho
Copy link
Contributor

prudho commented Sep 4, 2018

Seems to be introduced by 1dea0bf.

@ColinFrick it should be fixable by changing this code:

.ui.accordion .content:not(.active),
.ui.accordion .accordion .content:not(.active) {
  display: none;
}

With this code:

.ui.accordion > .content:not(.active),
.ui.accordion .accordion > .content:not(.active) {
  display: none;
}

What do you think ?

@ColinFrick
Copy link
Member

I implemented it similar to the original state with :not(.active)

.ui.accordion .title ~ .content:not(.active),
.ui.accordion .accordion .title ~ .content:not(.active) {
  display: none;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

3 participants