From 81f7c2cc5b37ff18926b3f5b30de328698127428 Mon Sep 17 00:00:00 2001 From: Marco 'Lubber' Wienkoop Date: Fri, 3 Mar 2023 11:19:31 +0100 Subject: [PATCH] fix(modal): scrolling multple modals positioning When multiple modals are used and one of them got the scrolling class, the other non scrolling modals are position shifted right before they get hidden/overlayed --- src/definitions/modules/modal.less | 7 +++++-- src/themes/default/modules/modal.variables | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/definitions/modules/modal.less b/src/definitions/modules/modal.less index e43a23b2c9..4f3275f676 100755 --- a/src/definitions/modules/modal.less +++ b/src/definitions/modules/modal.less @@ -437,19 +437,22 @@ overflow: hidden; } .scrolling.dimmable > .dimmer { - justify-content: flex-start; + justify-content: center; position: fixed; } .scrolling.dimmable:not(body) > .dimmer { - justify-content: center; position: absolute; } .scrolling.dimmable.dimmed > .dimmer { overflow: auto; overscroll-behavior: @overscrollBehavior; } + .modals.dimmer .ui.scrolling.modal.fullscreen { + top: 0; + } .modals.dimmer .ui.scrolling.modal:not(.fullscreen) { margin: @scrollingMargin auto; + top: @scrollingTop; } /* Fix for Firefox, Edge, IE11 */ diff --git a/src/themes/default/modules/modal.variables b/src/themes/default/modules/modal.variables index 586850b84d..5e3b54f6c7 100755 --- a/src/themes/default/modules/modal.variables +++ b/src/themes/default/modules/modal.variables @@ -133,6 +133,7 @@ /* Scrolling Margin */ @scrollingMargin: 2rem; @mobileScrollingMargin: @mobileTopAlignedMargin; +@scrollingTop: 1em; /* Scrolling Content */ @scrollingContentMaxHeight: calc(80vh - 10rem);