Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor / rewrite Upload_ReactComponent.react.js #22

Open
fohrloop opened this issue Jan 15, 2021 · 8 comments
Open

Refactor / rewrite Upload_ReactComponent.react.js #22

fohrloop opened this issue Jan 15, 2021 · 8 comments
Assignees
Labels
enhancement make something better good first issue help wanted help wanted
Milestone

Comments

@fohrloop
Copy link
Owner

The Upload_ReactComponent.react.js would really need some refactoring. This would make further development a lot easier and the package more maintainable.

@fohrloop fohrloop added enhancement make something better good first issue help wanted help wanted labels Jan 15, 2021
@sorenwacker
Copy link

I would like to help, but I have no idea where to start. Is there a description on how to setup the development environment?

@fohrloop
Copy link
Owner Author

fohrloop commented Jan 29, 2021

I'm very happy to hear! You can read the instructions for setting the development environment in the CONTRIBUTING.md. Please just let me know if you need any other guidance.

@Vipulsh
Copy link
Contributor

Vipulsh commented Feb 25, 2021

Is this still being worked on? If not I would like to pick it up.

@fohrloop
Copy link
Owner Author

I have not done anything for this but I don't know if @soerendip has. Great to hear @Vipulsh if you want to help!

@Vipulsh
Copy link
Contributor

Vipulsh commented Feb 27, 2021

Alright, I will set up the dev environment first and then start working on it.

@Vipulsh
Copy link
Contributor

Vipulsh commented Mar 2, 2021

I have created a pull request after making some changes.

@fohrloop
Copy link
Owner Author

fohrloop commented Mar 4, 2021

Great! Thank you @Vipulsh, I will have a look and do some testing once I have some time :)

@fohrloop
Copy link
Owner Author

fohrloop commented Apr 1, 2021

There has been some new merges (e.g. #26), and the most up-to-date refactored branch is the v.0.5.0 release candidate: https://github.com/np-8/dash-uploader/tree/0.5.0

Some more refactoring could still be done. It might be useful to refactor with #21.

@fohrloop fohrloop added this to the 0.5.0 milestone Apr 1, 2021
@fohrloop fohrloop modified the milestones: 0.6.0, 0.7.0 Dec 31, 2021
@fohrloop fohrloop self-assigned this Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement make something better good first issue help wanted help wanted
Projects
None yet
Development

No branches or pull requests

3 participants