Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with MSVC C++20 modules #3254

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Fix build with MSVC C++20 modules #3254

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31816bd
Fix build with MSVC C++20 modules
Orvid Dec 29, 2022
d7f5d31
Update core.h
Orvid Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/fmt/core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,9 +395,9 @@ FMT_CONSTEXPR auto to_unsigned(Int value) ->
return static_cast<typename std::make_unsigned<Int>::type>(value);
}

FMT_MSC_WARNING(suppress : 4566) constexpr unsigned char section[] = "\u00A7";
FMT_CONSTEXPR auto is_utf8() -> bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need inline here because FMT_CONSTEXPR expands to nothing on compilers that don't support relaxed constexpr.

FMT_MSC_WARNING(suppress : 4566) constexpr unsigned char section[] = "\u00A7";

constexpr auto is_utf8() -> bool {
// Avoid buggy sign extensions in MSVC's constant evaluation mode (#2297).
using uchar = unsigned char;
return FMT_UNICODE || (sizeof(section) == 3 && uchar(section[0]) == 0xC2 &&
Expand Down