Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in Clang (r346892) with C++2a #932

Closed
christinaa opened this issue Nov 17, 2018 · 1 comment · Fixed by #933
Closed

Regression in Clang (r346892) with C++2a #932

christinaa opened this issue Nov 17, 2018 · 1 comment · Fixed by #933

Comments

@christinaa
Copy link

christinaa commented Nov 17, 2018

The problem is here:

enum char8_t : unsigned char {};

LLVM/Clang revision 346892 makes char8_t a fundamental type in C++2a mode. Would it be possible to introduce a workaround in fmtlib to account for that? I could do a PR myself but I'm not sure what the best way of approaching it is.

Thank you.

@christinaa
Copy link
Author

Quick and dirty fix:

#if !defined(__cpp_char8_t)
// A UTF-8 code unit type.
enum char8_t : unsigned char {};
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant