Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC warning #1493

Closed
Naios opened this issue Dec 26, 2019 · 1 comment
Closed

MSVC warning #1493

Naios opened this issue Dec 26, 2019 · 1 comment

Comments

@Naios
Copy link
Contributor

Naios commented Dec 26, 2019

b6e19e5

MSVC 2017 15.9.18 throws the following warning:

fmt\include\fmt\format-inl.h(1354): warning C4267: warning C4267: 'Argument': conversion from 'size_t' to 'DWORD', possible loss of data

fmt/include/fmt/format-inl.h

Lines 1353 to 1354 in b6e19e5

if (!WriteConsoleW(reinterpret_cast<HANDLE>(_get_osfhandle(fd)),
u16.c_str(), u16.size(), &written, nullptr)) {

@chronoxor
Copy link
Contributor

#1492

@vitaut vitaut closed this as completed Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vitaut @Naios @chronoxor