From aa741bafe6cf3c521f44b88e1d63af832b115b3e Mon Sep 17 00:00:00 2001 From: vitaut Date: Tue, 10 Nov 2015 06:40:20 -0800 Subject: [PATCH] Don't assume that char_traits::compare returns +/-1 (#225) --- test/util-test.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/util-test.cc b/test/util-test.cc index 04c38844519f..07b10cd0cc93 100644 --- a/test/util-test.cc +++ b/test/util-test.cc @@ -724,8 +724,8 @@ void CheckOp() { TEST(UtilTest, StringRefCompare) { EXPECT_EQ(0, StringRef("foo").compare(StringRef("foo"))); - EXPECT_EQ(1, StringRef("fop").compare(StringRef("foo"))); - EXPECT_EQ(-1, StringRef("foo").compare(StringRef("fop"))); + EXPECT_GT(StringRef("fop").compare(StringRef("foo")), 0); + EXPECT_LT(StringRef("foo").compare(StringRef("fop")), 0); EXPECT_EQ(1, StringRef("foo").compare(StringRef("fo"))); EXPECT_EQ(-1, StringRef("fo").compare(StringRef("foo"))); CheckOp();