From a242bdabed1c20312b296001dbb571efa20bc75f Mon Sep 17 00:00:00 2001 From: Sunny Date: Thu, 14 Dec 2023 10:01:02 +0000 Subject: [PATCH] helmrepo: Remove migration log event This will be logged/event emitted forever once in the lifecycle of HelmRepository OCI object because all new objects have to remove the .status.observedGeneration which is set to -1 by the API defaulting. Better to perform the object conversion internally without any log or event. Signed-off-by: Sunny --- internal/controller/helmrepository_controller.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/controller/helmrepository_controller.go b/internal/controller/helmrepository_controller.go index 27663c625..d48b3c2f8 100644 --- a/internal/controller/helmrepository_controller.go +++ b/internal/controller/helmrepository_controller.go @@ -727,7 +727,5 @@ func (r *HelmRepositoryReconciler) migrationToStatic(ctx context.Context, sp *pa return ctrl.Result{}, err } - r.eventLogf(ctx, obj, eventv1.EventTypeTrace, "Migration", - "removed artifact and finalizer to migrate to static HelmRepository of type OCI") return ctrl.Result{}, nil }