Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract auto-login code to fluxcd/pkg #264

Closed
stefanprodan opened this issue May 27, 2022 · 1 comment · Fixed by #293
Closed

Extract auto-login code to fluxcd/pkg #264

stefanprodan opened this issue May 27, 2022 · 1 comment · Fixed by #293
Labels
enhancement New feature or request

Comments

@stefanprodan
Copy link
Member

As described in the RFC Flux OCI support for Kubernetes manifests, source-controller will have to use the same flags and authentication logic for Azure, AWS and Google Cloud as implemented in this controller.

We need to extract the auto-login code and the flags: --aws-autologin-for-ecr, --azure-autologin-for-acr, --gcp-autologin-for-gcr to a dedicated package in fluxcd/pkg/oci/auth so that we can share the code between image-reflector-controller and source-controller.

@stefanprodan stefanprodan added the enhancement New feature or request label May 27, 2022
@withnale
Copy link

I was searching for this issue on the source-controller but have found it here. Is there an eta on this?

The workload-identity logic works well in image-reflector, but I assume to get source-controller (and HelmRepository) able to use oci: then this card will need to be actioned and this logic be available in both apps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants