Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrde Helm to 3.14.0 or later (fixes issue in treatment of parent/child chart treatment) #878

Closed
joaocc opened this issue Jan 30, 2024 · 5 comments · Fixed by #879
Closed

Comments

@joaocc
Copy link

joaocc commented Jan 30, 2024

Hi,
After a lot of pain trying to identify why a non-trivial chart with subcharts was resulting in strange values, we found out this issue helm/helm#12480 and helm/helm#12460.
It seems that helm 3.13 changed the priority of parent/child values, which was then fixed in helm 3.14.0.
We would kindly ask if this could be included in an emergency release of the controller (and then propagated to flux or get some indications how it can be deployed)?
We believe this fix is critical, to fix the regression caused by 3.13.
Thanks

@stefanprodan
Copy link
Member

stefanprodan commented Jan 30, 2024

Helm 3.14.0 comes with Kubernetes 1.29 while Flux controller runtime is on Kubernetes 1.28, we need to migrate all controllers to 1.29 APIs and client-go before we can make a release with this. At best we can try create a RC build for helm-controller after we release Flux v2.2.3 this week fluxcd/flux2#4556

@joaocc
Copy link
Author

joaocc commented Jan 30, 2024

Thanks. Anything that could help in reverting to a stable behaviour in lens helps :)

@stefanprodan
Copy link
Member

@joaocc you can use the controller image posted here to switch to Helm 3.14 #879

@joaocc
Copy link
Author

joaocc commented Jan 31, 2024

Thanks for the suggestion. We will take a look to the technique, and try to adopt to our deployment strategy (helm + custom bootstrapping from terraform), and point image tag to preview-0d77acf1.
Thanks for the prompt response.

@joaocc
Copy link
Author

joaocc commented Mar 18, 2024

Hi. The workaround worked very well (sorry for not having provided feedback sooner). Thanks!
Shall we point the image to v0.37.4-helm3140 (as per #879) or it's better to wait for next full flux2 release?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants