Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-controller sharding not working in 2.2.1 #4500

Closed
1 task done
MaxRink opened this issue Dec 19, 2023 · 2 comments · Fixed by fluxcd/helm-controller#858
Closed
1 task done

helm-controller sharding not working in 2.2.1 #4500

MaxRink opened this issue Dec 19, 2023 · 2 comments · Fixed by fluxcd/helm-controller#858

Comments

@MaxRink
Copy link

MaxRink commented Dec 19, 2023

Describe the bug

We have two instances of the helm operator in each cluster, one for platform components, another one for everything else.
With the latest release both controllers try to reconcile all HRs, which leads to 'interesting' behaviour
e.g.

  Normal   UpgradeSucceeded     26m                helm-controller  Helm upgrade succeeded for release schiff-system/schiff-network.v2 with chart schiff-network@0.1.0
  Warning  UpgradeFailed        26m                helm-controller  Helm upgrade failed for release schiff-system/schiff-network with chart schiff-network@0.1.0: release: already exists

Steps to reproduce

Flux 1 has:
--watch-label-selector=sharding.fluxcd.io/key=platform
Flux 2 has:
--watch-label-selector=sharding.fluxcd.io/key notin (platform)
i also tried
--watch-label-selector=!sharding.fluxcd.io/key
just to make sure (which is in the current docs)
Both worked in the past and there was no change in any of the changelogs

The HRs either have

  labels:
    sharding.fluxcd.io/key: platform

or no label at all

Expected behavior

The sharding works as expected.

Screenshots and recordings

No response

OS / Distro

N/A

Flux version

v2.2.1

Flux check

N/A

Git provider

No response

Container Registry provider

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MaxRink MaxRink changed the title Sharding not working in 2.2.1 helm-controller sharding not working in 2.2.1 Dec 19, 2023
@hiddeco
Copy link
Member

hiddeco commented Dec 19, 2023

Sorry you had to run into this Max. We addressed this in the above PR, and CI is currently building v0.37.2 which should be available in a couple minutes. As soon as that's available, I will do an emergency release of the CLI as well.

But in the meantime, updating just the controller should be sufficient.

@hiddeco
Copy link
Member

hiddeco commented Dec 19, 2023

Now available as https://github.com/fluxcd/flux2/releases/tag/v2.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants