Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Support alternative fluxcd.io annotations #2217

Closed
squaremo opened this issue Jul 3, 2019 · 1 comment · Fixed by #2219
Closed

Support alternative fluxcd.io annotations #2217

squaremo opened this issue Jul 3, 2019 · 1 comment · Fixed by #2219

Comments

@squaremo
Copy link
Member

squaremo commented Jul 3, 2019

The annotations that are interpreted by flux will need to change, since they include the domain weave.works. But we don't want to just replace them, since that will break many installations (e.g., by not ignoring something that is supposed to be ignored). So: for some fairly large window, we'll need to support both sets of annotations.

@squaremo
Copy link
Member Author

squaremo commented Jul 3, 2019

Q: do we want to rewrite the old annotations to new annotations, as they are updated? Not all policies get updated by fluxd, and this might end up creating a confusion of annotations. Perhaps it would be better to use whichever were there, and deprecate the original prefix when we (inevitably) break backward compatibility, down the road a bit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant