Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code on Step 4 in 'Building layouts' page #8922

Closed
Tracked by #9738
nanselmo opened this issue Jun 22, 2023 · 1 comment
Closed
Tracked by #9738

Fix code on Step 4 in 'Building layouts' page #8922

nanselmo opened this issue Jun 22, 2023 · 1 comment
Assignees
@atsansone
Labels
a.tut.tutorial Relates to the Tutorial section of docs.flutter.dev cl.fixed Issue is closed as fixed e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. t.ui.layout Relates to layout of UI components

Comments

@nanselmo
Copy link

nanselmo commented Jun 22, 2023 •
edited by atsansone
Loading

Page URL

https://docs.flutter.dev/ui/layout/tutorial/

Page source

https://github.com/flutter/website/tree/main/src/ui/layout/tutorial.md

Describe the problem

In Step 4, the instructions indicate using a Container widget, but the sample code doesn't use a Container widget, and uses a Padding() widget instead.

Expected fix

Two choices

  1. Update the instructions to indicate using a Padding widget
  2. Update the code to use a Container widget

Additional context

I don't know enough Flutter to know which widget choice is more common or adventageous. The Container widget can provide more properties, if more than just Container.padding is needed in the future.
@atsansone atsansone added from.page-issue Reported in a reader-filed concern t.ui.layout Relates to layout of UI components labels Jun 22, 2023
@atsansone atsansone changed the title [PAGE ISSUE]: 'Building layouts' Fix code on Step 4 in 'Building layouts' page Jun 22, 2023
@atsansone atsansone added p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Effort: < 8 hrs st.triage.ltw labels Jun 22, 2023
@atsansone atsansone mentioned this issue Jun 26, 2023
Closed
@atsansone atsansone added the a.tut.tutorial Relates to the Tutorial section of docs.flutter.dev label Jun 28, 2023
@atsansone atsansone self-assigned this Oct 31, 2023
@atsansone atsansone added the cl.fixed Issue is closed as fixed label Nov 13, 2023
@atsansone
Copy link
Contributor

This was fixed in #9088. Closing.

@atsansone atsansone mentioned this issue Nov 13, 2023
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atsansone atsansone

Labels
a.tut.tutorial Relates to the Tutorial section of docs.flutter.dev cl.fixed Issue is closed as fixed e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. t.ui.layout Relates to layout of UI components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atsansone @nanselmo