From 8d1acdd74b1b2b42141b4922f0f72c8839974b85 Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Mon, 9 Sep 2024 09:41:43 -0700 Subject: [PATCH] [google_maps_flutter] Disable setAndGetScrollPosition on iOS (#7609) Disables tests that are suddenly flaking very badly and keeping the tree closed. Tracked in https://github.com/flutter/flutter/issues/154826 --- .../example/integration_test/webview_flutter_test.dart | 3 ++- .../example/integration_test/legacy/webview_flutter_test.dart | 3 ++- .../example/integration_test/webview_flutter_test.dart | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart b/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart index 414471881e6d..eaf9d7ea3094 100644 --- a/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart +++ b/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart @@ -568,7 +568,8 @@ Future main() async { }); }, // Scroll position is currently not implemented for macOS. - skip: Platform.isMacOS); + // Flakes on iOS: https://github.com/flutter/flutter/issues/154826 + skip: Platform.isMacOS || Platform.isIOS); group('NavigationDelegate', () { const String blankPage = ''; diff --git a/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart b/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart index 4ddecc87e4e1..f6bf750071d3 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart +++ b/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart @@ -893,7 +893,8 @@ Future main() async { }); }, // Scroll position is currently not implemented for macOS. - skip: Platform.isMacOS); + // Flakes on iOS: https://github.com/flutter/flutter/issues/154826 + skip: Platform.isMacOS || Platform.isIOS); group('NavigationDelegate', () { const String blankPage = ''; diff --git a/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart b/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart index b2915ea4403c..6f9256687df0 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart +++ b/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart @@ -808,7 +808,8 @@ Future main() async { }); }, // Scroll position is currently not implemented for macOS. - skip: Platform.isMacOS); + // Flakes on iOS: https://github.com/flutter/flutter/issues/154826 + skip: Platform.isMacOS || Platform.isIOS); group('NavigationDelegate', () { const String blankPage = '';