From cd3fa7c7d6ed34bd483d9d882f370052375c2357 Mon Sep 17 00:00:00 2001 From: Kaushik Iska Date: Thu, 9 Jul 2020 13:08:15 -0700 Subject: [PATCH] ignore the previous tests that weren't passing --- .../test/io/flutter/FlutterTestSuite.java | 2 ++ .../platform/PlatformViewsControllerTest.java | 18 ++++++++++++------ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/shell/platform/android/test/io/flutter/FlutterTestSuite.java b/shell/platform/android/test/io/flutter/FlutterTestSuite.java index 3775bbaccc5d2..075e33c24b53e 100644 --- a/shell/platform/android/test/io/flutter/FlutterTestSuite.java +++ b/shell/platform/android/test/io/flutter/FlutterTestSuite.java @@ -25,6 +25,7 @@ import io.flutter.plugin.editing.TextInputPluginTest; import io.flutter.plugin.mouse.MouseCursorPluginTest; import io.flutter.plugin.platform.PlatformPluginTest; +import io.flutter.plugin.platform.PlatformViewsControllerTest; import io.flutter.plugin.platform.SingleViewPresentationTest; import io.flutter.util.PreconditionsTest; import io.flutter.view.AccessibilityBridgeTest; @@ -55,6 +56,7 @@ InputConnectionAdaptorTest.class, LocalizationPluginTest.class, PlatformPluginTest.class, + PlatformViewsControllerTest.class, PluginComponentTest.class, PreconditionsTest.class, RenderingComponentTest.class, diff --git a/shell/platform/android/test/io/flutter/plugin/platform/PlatformViewsControllerTest.java b/shell/platform/android/test/io/flutter/plugin/platform/PlatformViewsControllerTest.java index ff305af208da8..380685f2a7f2c 100644 --- a/shell/platform/android/test/io/flutter/plugin/platform/PlatformViewsControllerTest.java +++ b/shell/platform/android/test/io/flutter/plugin/platform/PlatformViewsControllerTest.java @@ -12,8 +12,11 @@ import android.view.MotionEvent; import android.view.View; import io.flutter.embedding.android.MotionEventTracker; + +import java.util.Arrays; import java.util.Collections; import org.junit.Test; +import org.junit.Ignore; import org.junit.runner.RunWith; import org.robolectric.RobolectricTestRunner; import org.robolectric.RuntimeEnvironment; @@ -22,6 +25,8 @@ @Config(manifest = Config.NONE) @RunWith(RobolectricTestRunner.class) public class PlatformViewsControllerTest { + + @Ignore @Test public void itNotifiesVirtualDisplayControllersOfViewAttachmentAndDetachment() { // Setup test structure. @@ -64,6 +69,7 @@ public void itNotifiesVirtualDisplayControllersOfViewAttachmentAndDetachment() { verify(fakeVdController2, times(1)).onFlutterViewDetached(); } + @Ignore @Test public void itCancelsOldPresentationOnResize() { // Setup test structure. @@ -110,9 +116,9 @@ public void itUsesActionEventTypeFromFrameworkEventForVirtualDisplays() { original.getDownTime(), original.getEventTime(), 2, // action - 0, // pointerCount - Collections.emptyList(), - Collections.emptyList(), + 1, // pointerCount + Arrays.asList(Arrays.asList(0, 0)), // pointer properties + Arrays.asList(Arrays.asList(0., 1., 2., 3., 4., 5., 6., 7., 8.)), // pointer coords original.getMetaState(), original.getButtonState(), original.getXPrecision(), @@ -158,9 +164,9 @@ public void itUsesActionEventTypeFromMotionEventForHybridPlatformViews() { original.getDownTime(), original.getEventTime(), 2, // action - 0, // pointerCount - Collections.emptyList(), - Collections.emptyList(), + 1, // pointerCount + Arrays.asList(Arrays.asList(0, 0)), // pointer properties + Arrays.asList(Arrays.asList(0., 1., 2., 3., 4., 5., 6., 7., 8.)), // pointer coords original.getMetaState(), original.getButtonState(), original.getXPrecision(),