Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addFill() implementation does not use its data parameter #471

Closed
tfvtti opened this issue Dec 3, 2020 · 0 comments · Fixed by #501
Closed

addFill() implementation does not use its data parameter #471

tfvtti opened this issue Dec 3, 2020 · 0 comments · Fixed by #501
Labels
bug Something isn't working

Comments

@tfvtti
Copy link

tfvtti commented Dec 3, 2020

Using mapbox_gl-0.9.0, it appears that MapboxMapController's addFill() method has the 'data' parameter but the implementation of addFill() doesn't use the 'data' parameter.

Snippet from /Users/***/flutter/.pub-cache/hosted/pub.dartlang.org/mapbox_gl-0.9.0/lib/src/controller.dart:

Future<Fill> addFill(FillOptions options, [Map data]) async {
    final FillOptions effectiveOptions =
        FillOptions.defaultOptions.copyWith(options);
    final fill = await MapboxGlPlatform.getInstance(_id).addFill(effectiveOptions);
    _fills[fill.id] = fill;
    notifyListeners();
    return fill;
  }

I've verified that I can specify the 'data' parameter on addCircle() and later retrieve the value from controller.circles but not so for fills.

I started this project by copying the flutter mapbox example but I've cleared the pub-cache and run flutter clean and run pub get so I dont see how I could have an outdated mapbox plugin, but just in case I've attached output from flutter doctor and a copy of pubspec.yaml.

flutter_doctor.txt
pubspec_yaml.txt

@tobrun tobrun added the bug Something isn't working label Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants