Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking schedules on stop #93

Closed
tallesl opened this issue Aug 7, 2016 · 7 comments
Closed

Blocking schedules on stop #93

tallesl opened this issue Aug 7, 2016 · 7 comments

Comments

@tallesl
Copy link
Contributor

tallesl commented Aug 7, 2016

The current JobManager.Stop just stops the library main timer but it doesn't block the currently running schedules.

A JobManager.StopAndBlock would be nice.

@tallesl tallesl added the on hold label Aug 7, 2016
@tallesl tallesl changed the title Blocking the tasks when stopping Blocking schedules on stop Aug 8, 2016
@mdissel
Copy link
Contributor

mdissel commented Aug 25, 2016

Any progress? I'm currently using a static variable to detect a Stop (of my windows service) and stop the activities of the current active job.

@tallesl
Copy link
Contributor Author

tallesl commented Aug 29, 2016

@mdissel

Sorry, no progress so far. But this is the easiest to implement of all open issues, I believe that in the next week or so I have it done.

@skorunka
Copy link

skorunka commented Sep 6, 2016

+1

@tallesl
Copy link
Contributor Author

tallesl commented Oct 19, 2016

I believe that in the next week or so I have it done.

What a lie. Sorry for taking so long guys...

I just finished the implementation (was really simple after all).
I still have to finish a pull request here and an issue there, but as soon I have it published on NuGet I let you know here.

@tallesl
Copy link
Contributor Author

tallesl commented Nov 5, 2016

Published on version 5.1.0.

@AlbertoCe
Copy link

Great ! Thank you !

@nield
Copy link

nield commented Feb 24, 2017

Hi, would it be possible to add a timeout parameter? When timeout is reached the scheduler stops.

I used StopAndBlock(), but due to a database connection error, I could not stop my windows service.

Thanks for an awesome library 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants