Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash calling load without arguments #60

Closed
jamesb93 opened this issue Oct 27, 2021 · 2 comments · Fixed by #61
Closed

Crash calling load without arguments #60

jamesb93 opened this issue Oct 27, 2021 · 2 comments · Fixed by #61
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jamesb93
Copy link
Member

Patch and Crash attached. When I try to call load (incorrectly albeit) using a trigger object Max is sad and crashes.

Patch

----------begin_max5_patcher----------
1243.3oc6YtsiihCD.84juBDOtJaD9B21ekUihbBNY7LD.AN8zyLZlu80TF5
lzcHXnqr6KqTDHb.Jeppbcw7y0q72W9rrw26u79auUq945UqfgZGXU20q7OK
d9PtnAtM+B42J2+E+M1+RKeVCCmIOJqyK+V+eTb4rpHWpgGhzMXkPe3yphS6
pkGzVgRhC1FrwiDvZOExaORoaC79zqunxK529lrCo+dkz9Z78e4ATYvDxLI+
Spe6P+Z851CabDv8Wz5xhYyACl57H..d+w4hwdQwoahRRp+KBuVbVpk06jEh
84vSFr.NGwPp8xKEYdGxkh54aLo.3j1iQwSXKoioDZm.9a77sygapMh8wj38
d4yEUNMxZuAVooaCWFqfAeyH9uIQHhYsQ1RuiJstVTzbrr97MYlNNyLqONi.
nmltT6637FhNuVeo4wIMxFSJEhIEQwmSNhbVUqJzy18k.Vu3jPvhNEhA2fgf
kvvYYSi3j7cPLd3l6Xm31jFIL3DKD0bGbJpgXTy1BYielXMTjzkBWqyws3ik
h6ZshYuLiGk.9fw.arTTMerDDbOckjPVv.RBCvkDLy08GlJsB1tTKkcgFew7
czDMdDuQLiHpLEGM+kaQsoviRsQQvMVBisD5TZn7ttWWi5GfLL1uYa8.zRC.
nhCff8owCXyTPvI3kSCF91uQNtbUg7PYdYcWAesuJi6.ILJIhFyCCRSB32bH
x.4cyfTada0uElxbAEQuJPcpnzfUt5vWGZCFpno2sJ4dGkxx7gu.POuKSnE1
oSKS++OG+48I7V39YUitzeYt2I1h1X7kVsVmO3n4KIHFg5G4aaLtwROxrokY
iSYCBGFhdsozDD4LScPucQgi6vzVgGOF2sE.+1pffGKyTFFYayfguojhYI5m
j5kgYWmxovoPJplRRJxdqKjtPZeoe2ee.3iQWqrUkEh5uClyM2wrRheol.wS
xrclwLSmcBSi8p8FmwlNx6Peku77dY1fDf2M63v+7rnp5psXxpnwxiJ6x4pk
tGD1cJD4lFHOf.CKfw9UL1sQLB+8YgvPjyi4WTYaaiLzH0+1qXrMVhLsQMAZ
yfPHSPLapcSy1nwn3i5VWLbG0f.jiqBldOmnLHUGw5AflicJ516VFE4ldR98
bM18jl.mRYOVac7iySezjgSuC4DaZPRP7C1SeH8vM.cv8lO3CLOaG+ZURS4k
5C8xy94Tf586DSlrQqJDsYsFbOD+w6IvU4jD6ffnXHnTGDT+r4iiDYBIwtVA
eVkUUZZGoyZQsejAtsj+THF4UWj18smhd2EIV+Ld7qW8Zu30Yx5w+FR3BH4A
AXbWFyP1MtxtA9cvCW8d3IeL3CcYkQDF9QQNnlIX3wZpQvg0FnwzjZuTDjTq
dgNERgXfD2AjvfHhKDwQPPLWHhccP.jBsvbwSj8uGjIWcSHEBg4TpnfGgnoI
tD5lgf9k6REDuIKHRNQtIZx+Yl1wD8GboShKhFi.Qv72oBbHXHIWch9XKLbI
wDMACI4h2IEijsDWpSihg1i3haONkp3TADAXHo.Gx2RvHToKJu2q6rs3Ippd
RV2zcyfHL829E6GsKYCbopvdIrkD90xmT82OrOf9hZSqqZSeqWpseDtmi391
GszDZp3hpKvnANiHgdma+fcMUBKGPK1q+05+Aun5FOC
-----------end_max5_patcher-----------
Crash

Max_2021-10-27-122105_Jamess-MacBook-Pro-2.crash.zip

@jamesb93 jamesb93 added bug Something isn't working low priority labels Oct 27, 2021
@weefuzzy
Copy link
Member

The problem is actually calling load without arguments. It should give an error and bail – it actually gives and error but then tries to go ahead and dereference a non-existent pointer, which I've heard is bad.

if (ac < 2 || atom_getsym(av) != dictionarySymbol)
{
object_error((t_object*) x, "Expected a dictionary");
}
t_symbol* dictName = atom_getsym(av + 1);
t_dictionary* d = dictobj_findregistered_retain(dictName);

Will rename the issue accordingly.

@weefuzzy weefuzzy changed the title Crash when loading a fluid.dataset~ via trigger object Crash calling load without arguments Oct 27, 2021
@weefuzzy weefuzzy added this to the beta 4 milestone Oct 27, 2021
@weefuzzy weefuzzy self-assigned this Oct 27, 2021
@jamesb93
Copy link
Member Author

Cheers. Thanks for looking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants