From 93a6b7f4337c06feb9050fdf82b15ba24030e3b3 Mon Sep 17 00:00:00 2001 From: Oliver Ford Date: Wed, 22 Feb 2023 11:41:58 +0000 Subject: [PATCH] fix: mutating extant resources not forcing new Relates to #154, #19. --- docs/resources/machine.md | 2 +- internal/provider/app_resource.go | 6 ++++++ internal/provider/machine_resource.go | 5 ++++- internal/provider/volume_resource.go | 3 +++ 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/docs/resources/machine.md b/docs/resources/machine.md index dcd47f7..16b2bc3 100644 --- a/docs/resources/machine.md +++ b/docs/resources/machine.md @@ -87,7 +87,7 @@ resource "fly_machine" "exampleMachine" { Required: - `path` (String) Path for volume to be mounted on vm -- `volume` (String) Name or ID of volume +- `volume` (String) ID of volume Optional: diff --git a/internal/provider/app_resource.go b/internal/provider/app_resource.go index a12f6aa..bf19a14 100644 --- a/internal/provider/app_resource.go +++ b/internal/provider/app_resource.go @@ -44,12 +44,18 @@ func (ar flyAppResourceType) GetSchema(context.Context) (tfsdk.Schema, diag.Diag MarkdownDescription: "Name of application", Required: true, Type: types.StringType, + PlanModifiers: tfsdk.AttributePlanModifiers{ + resource.RequiresReplace(), + }, }, "org": { Computed: true, Optional: true, MarkdownDescription: "Optional org slug to operate upon", Type: types.StringType, + PlanModifiers: tfsdk.AttributePlanModifiers{ + resource.RequiresReplace(), + }, }, "orgid": { Computed: true, diff --git a/internal/provider/machine_resource.go b/internal/provider/machine_resource.go index 3f689c5..7702ace 100644 --- a/internal/provider/machine_resource.go +++ b/internal/provider/machine_resource.go @@ -176,8 +176,11 @@ func (mr flyMachineResourceType) GetSchema(context.Context) (tfsdk.Schema, diag. }, "volume": { Required: true, - MarkdownDescription: "Name or ID of volume", + MarkdownDescription: "ID of volume", Type: types.StringType, + PlanModifiers: tfsdk.AttributePlanModifiers{ + resource.RequiresReplace(), + }, }, }), }, diff --git a/internal/provider/volume_resource.go b/internal/provider/volume_resource.go index c17ca2a..a0392c9 100644 --- a/internal/provider/volume_resource.go +++ b/internal/provider/volume_resource.go @@ -53,6 +53,9 @@ func (t flyVolumeResourceType) GetSchema(context.Context) (tfsdk.Schema, diag.Di MarkdownDescription: "Size of volume in gb", Required: true, Type: types.Int64Type, + PlanModifiers: tfsdk.AttributePlanModifiers{ + resource.RequiresReplace(), + }, }, "name": { MarkdownDescription: "name",