Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

IntelliSense mixed with word-based suggestions #100

Closed
micmro opened this issue Mar 28, 2017 · 4 comments
Closed

IntelliSense mixed with word-based suggestions #100

micmro opened this issue Mar 28, 2017 · 4 comments

Comments

@micmro
Copy link

micmro commented Mar 28, 2017

First of all thanks for creating this great extension 😄, just one little thing that bugs me a bit:

When using Flow, there are a lot of word-based suggestions mixed with the Flow-based IntelliSense (see screenshot below) which makes exploring richer object structures more tedious. In TypeScript on the contrary VS Code does not show any word-based suggestions.

Is the a reason for showing them and if not is it possible to turn them off?

Besides I noticed in this example that label is shown twice.

screen shot 2017-03-28 at 11 00 46 am

TypeScript example:
screen shot 2017-03-28 at 11 05 05 am

Sample code for MainNav.jsx used for screenshot:

// @flow

import React, { PureComponent } from 'react';

type DummyType = {
  /** Name for menu item */
  label: string;
  /** Url for link */
  url?: string;
}


class MainNav extends PureComponent {
  props: {
    test: DummyType
  }

  render() {
    const {test} = this.props;

    return (
      <div>
        {test.label}
      </div>
    )
  }
}

export default MainNav

Versions:
VS Code: 1.10.2
flowtype.flow-for-vscode: 0.5.0

@orta
Copy link
Contributor

orta commented Mar 28, 2017

Thanks for the great issue, I'm afraid it's a dupe of #97

I'm not sure if anyone has specifically explored the "remove the words used in the file" as I wonder if that comes from the default JS implementation. You're welcome to take a stab at seeing if that is feasible.

@sciolist
Copy link
Contributor

sciolist commented Apr 15, 2017

The 'words used in the file' suggestions also come from TypeScript, so they're the same issue. I've taken to just deleting the typescript extension folder but that's clearly not an optimal solution.

@yenbekbay
Copy link

I think we can close this now as a new option javascript.nameSuggestions was shipped in the latest VSCode version: microsoft/vscode@4514ddd.

@orta
Copy link
Contributor

orta commented Jun 9, 2017

👍 agree

@orta orta closed this as completed Jun 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants