Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Migrate from text-based CLI to Protobuf RPC #76

Open
str4d opened this issue May 31, 2023 · 1 comment · May be fixed by #104
Open

tools: Migrate from text-based CLI to Protobuf RPC #76

str4d opened this issue May 31, 2023 · 1 comment · May be fixed by #104

Comments

@str4d
Copy link
Contributor

str4d commented May 31, 2023

Currently the binaries in tools/ use the text-based CLI over the serial port to communicate with a Flipper Zero and run FAPs. We should instead use the start_rpc_session CLI command to drop into the Protobuf RPC control mode, using e.g. the prost crate. This would remove most of the hand-written CLI parsing logic, and probably be more accurate and flexible.

In particular, I am curious about whether PB_App.StartRequest is specifically a request to Applications that enables us to provide arguments to FAPs (which the text CLI loader open Applications foo.fap does not), or whether it is a request to loader (and thus the same as the text CLI).

@dcoles
Copy link
Collaborator

dcoles commented Jun 2, 2023

Absolutely agree. When implementing the current storage_cli code in tools/, I tried to keep it identical to the Python implementation because of just how fragile that kind of CLI driving is.

@str4d str4d linked a pull request Sep 2, 2023 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants